Bug 254388 - [image-set] Handle zero resolution and clamping negative resolutions in calc expressions
Summary: [image-set] Handle zero resolution and clamping negative resolutions in calc ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL: https://wpt.fyi/results/css/css-image...
Keywords: InRadar
: 256367 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-23 19:43 PDT by Tim Nguyen (:ntim)
Modified: 2023-05-20 21:07 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2023-03-23 19:43:38 PDT 
<rdar://problem/107167273>
Comment 2 Tim Nguyen (:ntim) 2023-03-23 21:14:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11906
Comment 3 Tim Nguyen (:ntim) 2023-05-04 13:18:52 PDT 
I took care of the WPT, morphing this to be about zero resolutions
Comment 4 Ryan Reno 2023-05-04 21:01:56 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13479
Comment 5 Ryan Reno 2023-05-20 12:53:49 PDT 
I figured out how to get clamping to work it was really easy. Just had to pass ValueType::NonNegative to consumeMetaConsumer to get forwarded into the calc function parser. Updated the PR.
Comment 6 Ryan Reno 2023-05-20 14:17:36 PDT 
correction: ValueRange::NonNegative
Comment 7 EWS 2023-05-20 18:52:38 PDT 
Committed 264298@main (f9cc497c0b28): <https://commits.webkit.org/264298@main>

Reviewed commits have been landed. Closing PR #13479 and removing active labels.
Comment 8 Tim Nguyen (:ntim) 2023-05-20 21:07:35 PDT 
*** Bug 256367 has been marked as a duplicate of this bug. ***