254388 – [image-set] Handle zero resolution and clamping negative resolutions in calc expressions

RESOLVED FIXED 254388

[image-set] Handle zero resolution and clamping negative resolutions in calc expressions

https://bugs.webkit.org/show_bug.cgi?id=254388

Summary [image-set] Handle zero resolution and clamping negative resolutions in calc ...

Tim Nguyen (:ntim)

Reported 2023-03-23 19:43:28 PDT

See https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering-2.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-03-23 19:43:38 PDT

<rdar://problem/107167273>

Tim Nguyen (:ntim)

Comment 2 2023-03-23 21:14:29 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11906

Tim Nguyen (:ntim)

Comment 3 2023-05-04 13:18:52 PDT

I took care of the WPT, morphing this to be about zero resolutions

Ryan Reno

Comment 4 2023-05-04 21:01:56 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13479

Ryan Reno

Comment 5 2023-05-20 12:53:49 PDT

I figured out how to get clamping to work it was really easy. Just had to pass ValueType::NonNegative to consumeMetaConsumer to get forwarded into the calc function parser. Updated the PR.

Ryan Reno

Comment 6 2023-05-20 14:17:36 PDT

correction: ValueRange::NonNegative

EWS

Comment 7 2023-05-20 18:52:38 PDT

Committed 264298@main (f9cc497c0b28): <https://commits.webkit.org/264298@main> Reviewed commits have been landed. Closing PR #13479 and removing active labels.

Tim Nguyen (:ntim)

Comment 8 2023-05-20 21:07:35 PDT

*** Bug 256367 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.