RESOLVED WONTFIX254376
Random fixes from CPPChecker done in Blink 
https://bugs.webkit.org/show_bug.cgi?id=254376
Summary Random fixes from CPPChecker done in Blink
Ahmad Saleem
Reported 2023-03-23 15:53:41 PDT
Hi Team, While going through Blink's commit, I came across following fixes identified by CPPChecker and done by Blink. Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=165481 There are some which we can import or merge, just raising to get input. Similar to this was delete: https://searchfox.org/wubkat/source/Source/WebCore/rendering/style/RenderStyle.h#416 Deleted - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/LegacyRenderSVGShape.h#134 but we have three uses of it. This can be done safely - tried it in Local Build as well - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextQuery.cpp#198 While all others were ++it changing to it++ and changing == to !, which our style checker already take care of. I think from above, we can merge 'SVGTextQuery' only but just wanted to get input. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-30 15:54:21 PDT
<rdar://problem/107444097>
Ahmad Saleem
Comment 2 2023-10-21 03:11:48 PDT
SVGTextQuery change is no longer applicable - https://github.com/WebKit/WebKit/blob/2eed0466d7087a67e3b65404c23d3e1622e6ae15/Source/WebCore/rendering/svg/SVGTextQuery.cpp#L166 This function has changed due to recent optimizations. Only now to look into RenderStyle change otherwise we will be able to close it.
Ahmad Saleem
Comment 3 2023-10-21 03:22:39 PDT
m_textAlignLast <- I am unable to find it and the link where I found it earlier mentioned in Comment 0 is not working due to 'searchfox.org' not having revision specific link (could be my fault). Marking this as 'RESOLVED WONTFIX'.
Note You need to log in before you can comment on or make changes to this bug.