Bug 25430 - Enable loading style sheet for UI controls for media elements in Chromium port
Summary: Enable loading style sheet for UI controls for media elements in Chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-27 14:01 PDT by Hin-Chung Lam
Modified: 2009-04-29 13:14 PDT (History)
1 user (show)

See Also:


Attachments
patch + changelog (1.91 KB, patch)
2009-04-27 14:07 PDT, Hin-Chung Lam
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2009-04-27 14:01:58 PDT
Implement a virtual method in RenderTheme to provide style sheet for media controls in Chromium port.
Comment 1 Hin-Chung Lam 2009-04-27 14:07:35 PDT
Created attachment 29826 [details]
patch + changelog

Just the patch with change log, since <video> and <audio> in chromium is not ready to run through layout tests and the style for default ui is subject to change so no layout tests are provided. This patch is just to enable loading the  style sheet so change the default style sheet would have effects.
Comment 2 Sam Weinig 2009-04-27 16:04:48 PDT
In the future, please don't remove the NOBODY (OOPS!) from the ChangeLog.  We have post commit scripts that check to make sure the lander didn't forget to update the reviewer by checking for it. 
Comment 3 Eric Seidel (no email) 2009-04-29 13:14:33 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderThemeChromiumWin.cpp
	M	WebCore/rendering/RenderThemeChromiumWin.h
Committed r43002