Bug 254293 - REGRESSION(260512@main): canvas-drawImage-hdr-video.html has been consistently failing on the EWS bots
Summary: REGRESSION(260512@main): canvas-drawImage-hdr-video.html has been consistentl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-22 15:49 PDT by Said Abou-Hallawa
Modified: 2023-03-24 12:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-03-22 15:49:42 PDT 
This test draws a frame of an HDR video to a canvas, getImageData of a certain pixel from the canvas and then compares this pixel with an expected color. Because of 260512@main, the colorspace of the unaccelerated temporary buffer can be different on different platforms. So the drawn pixel might be slightly different from the expected pixel. We need to use a small tolerance when comparing these two pixels.
Comment 1 Radar WebKit Bug Importer 2023-03-22 15:51:02 PDT 
<rdar://problem/107083380>
Comment 2 Said Abou-Hallawa 2023-03-22 15:55:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11828
Comment 3 Said Abou-Hallawa 2023-03-22 17:02:51 PDT 
An example of the failure is here: https://ews-build.webkit.org/#/builders/36/builds/193
Comment 4 Said Abou-Hallawa 2023-03-24 06:48:25 PDT 
Pull request: https://github.com/WebKit/WebKit-security/pull/34
Comment 5 EWS 2023-03-24 12:35:36 PDT 
Committed 262092@main (dcbe4246df7c): <https://commits.webkit.org/262092@main>

Reviewed commits have been landed. Closing PR #11828 and removing active labels.