RESOLVED INVALID25427
Fix a bug in MediaDocument.cpp that gets triggered when entering a media file in address bar 
https://bugs.webkit.org/show_bug.cgi?id=25427
Summary Fix a bug in MediaDocument.cpp that gets triggered when entering a media file...
Hin-Chung Lam
Reported 2009-04-27 10:58:18 PDT
When MediaDocument receives the first call for data for the media document, it immediately construct the DOM structure and mark the parsing as finished but does not stop the resource loading of the media file, so when the next buffer is received a ASSERT is hit.
Attachments
change log + patch (1.07 KB, patch)
2009-04-28 19:16 PDT, Hin-Chung Lam 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-04-27 13:39:57 PDT
*** Bug 25429 has been marked as a duplicate of this bug. ***
Hin-Chung Lam
Comment 2 2009-04-28 19:16:51 PDT
Created attachment 29876 [details] change log + patch Another bug I filed was a duplicate so I submit the patch again here. I'm not so sure if there's any layout tests regarding MediaDocument and MediaTokenizer, please correct me if I need to have layout tests for this fix.
Eric Carlson
Comment 3 2009-04-29 08:38:46 PDT
Is there a way to reproduce this problem?
Hin-Chung Lam
Comment 4 2009-04-29 14:13:26 PDT
The steps I took: 1. Open Chromium nightly build 2. Enter a .mov address in the address bar 3. kaboom! I tried to reproduce it in Safari (or nightly WebKit) but no luck, I tried: 1. Remove all QuickTime plugins so it won't get delegated to QT 2. Enter a .mov address 3. Explorer opens and pointed me to the file
Eric Carlson
Comment 5 2009-05-01 17:25:19 PDT
This patch causes an OSX build to crash in DocumentLoader::cancelMainResourceLoad, called from -[WebHTMLRepresentation receivedData:withDataSource:] to stop resource loading. Brady Eidson added that call in http://trac.webkit.org/changeset/36001 to replace code that was essentially the same as what you are proposing here, so I don't think this approach is right.
Hin-Chung Lam
Comment 6 2009-05-01 17:44:59 PDT
I'll do a OSX build to verify and debug into it, thanks for the info!
Eric Seidel (no email)
Comment 7 2009-05-14 22:21:05 PDT
Comment on attachment 29876 [details] change log + patch Style violations { don't go on their own line for if's. also, why is this correct? does this match other Document.cpp finish() methods? Seems it needs a comment to that effect.
Eric Seidel (no email)
Comment 8 2009-05-14 22:21:37 PDT
Comment on attachment 29876 [details] change log + patch Also, we could at least make a manual test (see WebCore/manual-tests/) for this.
Note You need to log in before you can comment on or make changes to this bug.