Bug 254269 - @counter-styles: Single symbol "" does not behave correctly
Summary: @counter-styles: Single symbol "" does not behave correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vitor Roriz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-22 07:17 PDT by Vitor Roriz
Modified: 2023-03-22 10:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Roriz 2023-03-22 07:17:53 PDT 
For a system that accepts a single symbol, like cyclic, if we input a symbol that is an empty string,
the text representation is being considered invalid and it is falling back to 'decimal'.
This is is wrong, since empty string is a valid string.

Example:

  @counter-style foo {
    system: cyclic;
    symbols: "" "@";
    prefix: "";
    suffix: "";
  }
Comment 1 Radar WebKit Bug Importer 2023-03-22 07:18:04 PDT 
<rdar://problem/107053810>
Comment 2 Vitor Roriz 2023-03-22 08:13:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11810
Comment 3 Vitor Roriz 2023-03-22 09:19:33 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/39143
Comment 4 EWS 2023-03-22 10:34:37 PDT 
Committed 261971@main (140b74df15a9): <https://commits.webkit.org/261971@main>

Reviewed commits have been landed. Closing PR #11810 and removing active labels.