Bug 25424 – media/video-played.html test doesn't take in account synchronization with media playback

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pierre d'Herbemont]

media/video-played.html test doesn't take in account synchronization with media playback.

On slow machines this could results in failing tests.

[Pierre d'Herbemont]

Created attachment 29819 [details]
patch v1.

[Simon Fraser (smfr)]

Comment on attachment 29819 [details]
patch v1.

> +        Note, this does not ensure a strict synchronization between the time
> +        asked and the media playback. But given that media playback is the
> +        slow part we just need to compensate the delay involved by playback.

compensate _for_ the delay.


> +                    if (playedTime < 0) {
> +                        // Deal with loop. Workd only once, hence the warning

Typo here.

[Mark Rowe (bdash)]

*** Bug 25423 has been marked as a duplicate of this bug. ***

[Mark Rowe (bdash)]

*** Bug 25422 has been marked as a duplicate of this bug. ***

[Pierre d'Herbemont]

Created attachment 29823 [details]
patch v2.

This time we moreover split the test into three files in order to avoid timeout on slow machines.

[Pierre d'Herbemont]

Created attachment 29825 [details]
patch v3.

With ChangeLog this time.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/42920