V8LazyEventListener::getWrappedListenerFunction uses '\n' characters in the JavaScript code of the listener function wrapper. It requires additional logic when debugging pages to translate line numbers from the wrapper snippet to the original source. It seems that we can safely change the wrapper into a one-line expression and have line numbers of the wrapped handler to be the same as in the original code.
Created attachment 29817 [details] Patch removing all new line characters from the handler wrapper.
You should ensure that listeners specificed with a // style comment at the end still function correctly.
Created attachment 29843 [details] Remove all new lines except those going right after the original code
Fixed. I left one '\n' after the wrapped code so that //-style comments don't break the wrapper code. (In reply to comment #2) > You should ensure that listeners specificed with a // style comment at the end > still function correctly. >
Comment on attachment 29843 [details] Remove all new lines except those going right after the original code Code looks good, but ChangeLog entry is missing.
Created attachment 30130 [details] Patch with Changelog entry
(In reply to comment #5) > (From update of attachment 29843 [details] [review]) > Code looks good, but ChangeLog entry is missing. > I've added ChangeLog entry.
Comment on attachment 30130 [details] Patch with Changelog entry Next time, please add a URL to the ChangeLog entry: http://webkit.org/coding/contributing.html
Landed as http://trac.webkit.org/changeset/43707.