Steps to reproduce: 1. View the (to be) attached document in WebKit Gtk. 2. Examine any of the paragraphs (i.e. items formatted with <p></p>) and list items (i.e. items formatted with <li></li>) using Accerciser. Expected results: Paragraphs would be exposed as being of ROLE_PARAGRAPH; list items as ROLE_LIST_ITEM. Actual results: Paragraphs and list items are exposed as ROLE_PANEL.
Created attachment 29807 [details] aforementioned test case
Created attachment 30505 [details] paragraphrole.patch Implement ATK_ROLE_PARAGRAPH.
Created attachment 30506 [details] listitemrole.patch Implement ATK_ROLE_LIST_ITEM.
Comment on attachment 30506 [details] listitemrole.patch > + // WebCore does not seem to have a role for list items > + if (AXObject->roleValue() == GroupRole) { Why? List is not a child role of group so I don't think it's required (http://www.w3.org/TR/wai-aria/#group) > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > + if (parent && parent->roleValue() == ListRole) You can just isList() here instead.
Comment on attachment 30506 [details] listitemrole.patch > + // WebCore does not seem to have a role for list items > + if (AXObject->roleValue() == GroupRole) { isGroup() > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > + if (parent && parent->roleValue() == ListRole) isList() With those changes, r=me.
Comment on attachment 30505 [details] paragraphrole.patch Please check if we have a node() first just in case we may not have one. r=me.
(In reply to comment #5) > (From update of attachment 30506 [details] [review]) > > + // WebCore does not seem to have a role for list items > > + if (AXObject->roleValue() == GroupRole) { > > isGroup() > > > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > > + if (parent && parent->roleValue() == ListRole) > > isList() > > With those changes, r=me. > Thanks, landed as r43907.
(In reply to comment #6) > (From update of attachment 30505 [details] [review]) > Please check if we have a node() first just in case we may not have one. > > r=me. > Done so and landed as r43908.
Thanks Xan. Marking as VERIFIED.