WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25412
The Window object should be an EventTarget
https://bugs.webkit.org/show_bug.cgi?id=25412
Summary
The Window object should be an EventTarget
Sam Weinig
Reported
2009-04-26 14:47:55 PDT
The Window object should be a full fledged EventTarget and implement dispatchEvent.
Attachments
Patch [WIP]
(8.06 KB, patch)
2009-04-26 14:50 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
patch with tests
(14.07 KB, patch)
2009-04-26 16:53 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2009-04-26 14:50:12 PDT
Created
attachment 29805
[details]
Patch [WIP] This patch turns makes the DOMWindow an EventTarget but it is still a WIP as I have not had time to make tests yet. I will update when I next have a chance. I am putting this up so I don't lose it.
Sam Weinig
Comment 2
2009-04-26 14:50:40 PDT
A follow up patch should move more the window event dispatch code to DOMWindow.
Sam Weinig
Comment 3
2009-04-26 16:53:15 PDT
Created
attachment 29808
[details]
patch with tests
mitz
Comment 4
2009-04-26 16:57:54 PDT
Comment on
attachment 29808
[details]
patch with tests
> Index: WebCore/page/DOMWindow.h > =================================================================== > --- WebCore/page/DOMWindow.h (revision 42880) > +++ WebCore/page/DOMWindow.h (working copy) > @@ -30,6 +30,7 @@ > #include "PlatformString.h" > #include "RegisteredEventListener.h" > #include "SecurityOrigin.h" > +#include "EventTarget.h" > #include <wtf/Forward.h> > #include <wtf/RefCounted.h> > #include <wtf/RefPtr.h>
Please keep in ASCII order. r=me
Sam Weinig
Comment 5
2009-04-26 17:03:28 PDT
Landed in
r42882
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug