RESOLVED FIXED254099
MediaSample should use integer as track id rather than AtomString 
https://bugs.webkit.org/show_bug.cgi?id=254099
Summary MediaSample should use integer as track id rather than AtomString
Jean-Yves Avenard [:jya]
Reported 2023-03-17 19:07:55 PDT
All instances of track ID are using either int or uint ; except for MediaSample that is using AtomString forcing to have back and forth conversion whenever we are checking or searching for a track.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-17 19:08:55 PDT
<rdar://problem/106884653>
Jean-Yves Avenard [:jya]
Comment 2 2023-11-26 04:00:46 PST
Pull request: https://github.com/WebKit/WebKit/pull/20901
EWS
Comment 3 2023-12-01 22:00:41 PST
Committed 271419@main (b3ffcc0a9df7): <https://commits.webkit.org/271419@main> Reviewed commits have been landed. Closing PR #20901 and removing active labels.
Vivienne Watermeier
Comment 4 2024-09-04 06:38:35 PDT
I'm currently working on a similar patch for our GTK/WPE ports, and I'd like to ask for clarification on a few points: - How do you handle MediaStream? The spec suggests using UUIDs, and thats what we do so far. I've tried to see how TrackIDs are set in Apple ports, but I didn't find where that happens. - The commit mentions using StdUnorderedMap instead of HashMap, can you elaborate what the issue with HashMap is? Thanks!
Note You need to log in before you can comment on or make changes to this bug.