Bug 254099 - MediaSample should use integer as track id rather than AtomString
Summary: MediaSample should use integer as track id rather than AtomString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-17 19:07 PDT by Jean-Yves Avenard [:jya]
Modified: 2024-09-04 06:38 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-03-17 19:07:55 PDT 
All instances of track ID are using either int or uint ; except for MediaSample that is using AtomString forcing to have back and forth conversion whenever we are checking or searching for a track.
Comment 1 Radar WebKit Bug Importer 2023-03-17 19:08:55 PDT 
<rdar://problem/106884653>
Comment 2 Jean-Yves Avenard [:jya] 2023-11-26 04:00:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20901
Comment 3 EWS 2023-12-01 22:00:41 PST 
Committed 271419@main (b3ffcc0a9df7): <https://commits.webkit.org/271419@main>

Reviewed commits have been landed. Closing PR #20901 and removing active labels.
Comment 4 Vivienne Watermeier 2024-09-04 06:38:35 PDT 
I'm currently working on a similar patch for our GTK/WPE ports, and I'd like to ask for clarification on a few points:

- How do you handle MediaStream? The spec suggests using UUIDs, and thats what we do so far. I've tried to see how TrackIDs are set in Apple ports, but I didn't find where that happens.
- The commit mentions using StdUnorderedMap instead of HashMap, can you elaborate what the issue with HashMap is?

Thanks!