Bug 254052 - [git-webkit] Handle ssh protocol with user
Summary: [git-webkit] Handle ssh protocol with user
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-16 16:21 PDT by Jonathan Bedard
Modified: 2023-03-20 12:06 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-16 16:21:48 PDT 
The ssh protocol for git checkouts may define both the user and the protocol. Handle this case in our pre-push regex, and write a unit test for our regex so we can ennumerate any future configurations contributors stumble into.
Comment 1 Radar WebKit Bug Importer 2023-03-16 16:22:00 PDT 
<rdar://problem/106832995>
Comment 2 Jonathan Bedard 2023-03-16 16:28:14 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11629
Comment 3 EWS 2023-03-17 09:02:57 PDT 
Committed 261795@main (bb518ed01306): <https://commits.webkit.org/261795@main>

Reviewed commits have been landed. Closing PR #11629 and removing active labels.
Comment 4 EWS 2023-03-20 12:06:08 PDT 
Committed 259548.448@safari-7615-branch (5f13122febab): <https://commits.webkit.org/259548.448@safari-7615-branch>

Reviewed commits have been landed. Closing PR #480 and removing active labels.