Bug 25399 – WebKit Crashes on Lexis-Nexis

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Hayden]

WebKit Crashes on Lexis-Nexis

[Hayden]

Created attachment 29791 [details]
Crash Report from Lexis Nexis (RTF)

[Hayden]

Created attachment 29792 [details]
2nd Crash Report

[Mark Rowe (bdash)]

Can you provide more specific instructions on how to reproduce this crash?  Is simply loading the URL sufficient, or do specific links need to be clicked?

[Mark Rowe (bdash)]

<rdar://problem/6828178>

[Alexey Proskuryakov]

<rdar://problem/6633943>

One needs an account to reproduce this.

[Alexey Proskuryakov]

Created attachment 29814 [details]
proposed fix

Alas, I could not make a regression test, even after trying hard.

[Darin Adler]

Comment on attachment 29814 [details]
proposed fix

r=me

[Darin Adler]

Comment on attachment 29814 [details]
proposed fix

> +#ifndef NDEBUG
> +    DocumentResourceMap::iterator it = m_documentResources.find(resource->url());
> +    if (it != m_documentResources.end())
> +        ASSERT(it->second.get() == resource);
> +#endif

You could write this:

    ASSERT(!m_documentResources.contains(resource->url()) || m_documentResources.get(resource->url()) == resource);

I think it's a little easier to understand.

[Alexey Proskuryakov]

> I think it's a little easier to understand.

That's how I wrote it originally, but it was difficult to see why the assertion failed when stopped on it in the debugger.

[Darin Adler]

(In reply to comment #9)
> That's how I wrote it originally, but it was difficult to see why the assertion
> failed when stopped on it in the debugger.

OK.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/42896>.