Bug 25396 - REGRESSION (r34681): Text is no longer underlined after delete
Summary: REGRESSION (r34681): Text is no longer underlined after delete
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Adele Peterson
Depends on:
Reported: 2009-04-25 11:33 PDT by Adele Peterson
Modified: 2009-04-25 17:00 PDT (History)
2 users (show)

See Also:

test case (753 bytes, text/html)
2009-04-25 11:34 PDT, Adele Peterson
no flags Details
patch (42.67 KB, patch)
2009-04-25 11:38 PDT, Adele Peterson
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2009-04-25 11:33:34 PDT
See attached test case.

This was caused by http://trac.webkit.org/changeset/34681
In moveParagraphs, the style from the empty paragraph gets applied to the first line after the delete occurs.

I have a patch on the way...

Comment 1 Adele Peterson 2009-04-25 11:34:14 PDT
Created attachment 29787 [details]
test case
Comment 2 Adele Peterson 2009-04-25 11:38:00 PDT
Created attachment 29788 [details]
Comment 3 Justin Garcia 2009-04-25 16:56:42 PDT
This is the same as https://bugs.webkit.org/show_bug.cgi?id=24862 which Julie is actively working on.  I think I remember her saying that there was a case in which the strategy you used wouldn't work, but you'll have to ask her for the specifics.
Comment 4 Adele Peterson 2009-04-25 17:00:56 PDT
Hmm ok.  I checked in revision 42869, but I'll move this discussion over to the other bug.