Bug 253885 - WebGLRenderingContextBase texImageSource HTMLCanvasElement implementation unable to share code with OffscreenCanvas
Summary: WebGLRenderingContextBase texImageSource HTMLCanvasElement implementation una...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 253886
  Show dependency tree / graph
 
Reported: 2023-03-14 06:38 PDT by Kimmo Kinnunen
Modified: 2023-03-15 01:35 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-03-14 06:38:15 PDT 
WebGLRenderingContextBase texImageSource CanvasRenderingContext2D implementation unable to share code with OffscreenCanvas

The texImageSourceHelper invokes the std::variant cases directly inside the function body, making it difficult to share CanvasRenderingContext2D and OffscreenCanvas base implementation.
Comment 1 Radar WebKit Bug Importer 2023-03-14 06:40:14 PDT 
<rdar://problem/106699408>
Comment 2 Kimmo Kinnunen 2023-03-14 07:01:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11494
Comment 3 EWS 2023-03-15 01:35:13 PDT 
Committed 261678@main (23d40f46815d): <https://commits.webkit.org/261678@main>

Reviewed commits have been landed. Closing PR #11494 and removing active labels.