Now that the file is more than just a typedef and has scriptStateFromPage in it, it seems logical.
Created attachment 29774 [details] Move scriptStateFromNode to ScriptState, v1. WebCore/ChangeLog | 18 ++++++++++++++++++ WebCore/bindings/js/JSDOMBinding.cpp | 15 --------------- WebCore/bindings/js/JSDOMBinding.h | 2 -- WebCore/bindings/js/ScriptState.cpp | 16 ++++++++++++++++ WebCore/bindings/js/ScriptState.h | 6 +++--- WebCore/dom/NodeFilter.h | 1 - WebCore/dom/NodeIterator.h | 1 - WebCore/dom/TreeWalker.h | 1 - 8 files changed, 37 insertions(+), 23 deletions(-)
Comment on attachment 29774 [details] Move scriptStateFromNode to ScriptState, v1. Seems to be missing the V8 side of things...
Created attachment 29821 [details] Move scriptStateFromNode to ScriptState, v2. WebCore/ChangeLog | 19 +++++++++++++++++++ WebCore/bindings/js/JSDOMBinding.cpp | 15 --------------- WebCore/bindings/js/JSDOMBinding.h | 2 -- WebCore/bindings/js/ScriptState.cpp | 16 ++++++++++++++++ WebCore/bindings/js/ScriptState.h | 8 ++++---- WebCore/bindings/v8/ScriptState.cpp | 11 +++++++++++ WebCore/bindings/v8/ScriptState.h | 4 +++- WebCore/dom/NodeFilter.h | 1 - WebCore/dom/NodeIterator.h | 1 - WebCore/dom/TreeWalker.h | 1 - 10 files changed, 53 insertions(+), 25 deletions(-)
Comment on attachment 29821 [details] Move scriptStateFromNode to ScriptState, v2. I don't understand the #include <interpreter/CallFrame.h> include, but otherwise this looks fine!
Landed as http://trac.webkit.org/changeset/42901.