[WASM][Debug] Build issue for always true comparison in assertion

[Xabier Rodríguez Calvar]

[2251/7043] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o 
/usr/bin/ccache /usr/bin/g++ -DBUILDING_GTK__=1 -DBUILDING_JavaScriptCore -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKitGTK-4.1\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DJavaScriptCore_EXPORTS -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_WTF -DSTATICALLY_LINKED_WITH_bmalloc -I/app/webkit/WebKitBuild/Debug/JavaScriptCore/Headers -I/app/webkit/WebKitBuild/Debug -I/app/webkit/Source/JavaScriptCore -I/app/webkit/Source/JavaScriptCore/API -I/app/webkit/Source/JavaScriptCore/assembler -I/app/webkit/Source/JavaScriptCore/b3 -I/app/webkit/Source/JavaScriptCore/b3/air -I/app/webkit/Source/JavaScriptCore/bindings -I/app/webkit/Source/JavaScriptCore/builtins -I/app/webkit/Source/JavaScriptCore/bytecode -I/app/webkit/Source/JavaScriptCore/bytecompiler -I/app/webkit/Source/JavaScriptCore/dfg -I/app/webkit/Source/JavaScriptCore/disassembler -I/app/webkit/Source/JavaScriptCore/disassembler/ARM64 -I/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis -I/app/webkit/Source/JavaScriptCore/domjit -I/app/webkit/Source/JavaScriptCore/ftl -I/app/webkit/Source/JavaScriptCore/heap -I/app/webkit/Source/JavaScriptCore/debugger -I/app/webkit/Source/JavaScriptCore/inspector -I/app/webkit/Source/JavaScriptCore/inspector/agents -I/app/webkit/Source/JavaScriptCore/inspector/augmentable -I/app/webkit/Source/JavaScriptCore/inspector/remote -I/app/webkit/Source/JavaScriptCore/interpreter -I/app/webkit/Source/JavaScriptCore/jit -I/app/webkit/Source/JavaScriptCore/llint -I/app/webkit/Source/JavaScriptCore/parser -I/app/webkit/Source/JavaScriptCore/profiler -I/app/webkit/Source/JavaScriptCore/runtime -I/app/webkit/Source/JavaScriptCore/tools -I/app/webkit/Source/JavaScriptCore/wasm -I/app/webkit/Source/JavaScriptCore/wasm/js -I/app/webkit/Source/JavaScriptCore/yarr -I/app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources -I/app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/inspector -I/app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/runtime -I/app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/yarr -I/app/webkit/Source/JavaScriptCore/API/glib -I/app/webkit/WebKitBuild/Debug/JavaScriptCoreGLib/DerivedSources -I/app/webkit/WebKitBuild/Debug/JavaScriptCoreGLib/DerivedSources/jsc -I/app/webkit/WebKitBuild/Debug/JavaScriptCoreGLib/Headers -I/app/webkit/Source/JavaScriptCore/inspector/remote/glib -I/app/webkit/WebKitBuild/Debug/WTF/Headers -I/app/webkit/WebKitBuild/Debug/bmalloc/Headers -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overread -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -g -fPIC -fvisibility=hidden -ffp-contract=off -Werror -std=c++20 -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o -c /app/webkit/Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
In file included from /app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/StdLibExtras.h:34,
                 from /app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/FastMalloc.h:26,
                 from /app/webkit/Source/JavaScriptCore/config.h:39,
                 from /app/webkit/Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:26:
/app/webkit/Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: In member function ‘JSC::Wasm::BBQJIT::Location JSC::Wasm::BBQJIT::locationOfWithoutBinding(Value)’:
/app/webkit/Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:8716:36: error: comparison of unsigned expression in ‘>= 0’ is always true [-Werror=type-limits]
 8716 |             ASSERT(value.asLocal() >= 0 && value.asLocal() < m_locals.size());
      |                    ~~~~~~~~~~~~~~~~^~~~
/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/Assertions.h:363:11: note: in definition of macro ‘ASSERT’
  363 |     if (!(assertion)) { \
      |           ^~~~~~~~~

[Xabier Rodríguez Calvar]

I'm hitting this when building the GTK port in Debug but but I don't know if happens in other ports.

[Przemyslaw Gorszkowski]

Pull request: https://github.com/WebKit/WebKit/pull/11488

[Xabier Rodríguez Calvar]

*** This bug has been marked as a duplicate of bug 253880 ***