RESOLVED FIXED 25380
LayoutTests/media/video-played.html has a race condition when starting the test. 
https://bugs.webkit.org/show_bug.cgi?id=25380
Summary LayoutTests/media/video-played.html has a race condition when starting the test.
Pierre d'Herbemont
Reported 2009-04-24 15:37:52 PDT
LayoutTests/media/video-played.html has a race condition when starting the test. The test may attempt to call video.play() even before the 'canplay' event has been fired.
Attachments
patch v1. (2.18 KB, patch)
2009-04-24 15:39 PDT, Pierre d'Herbemont 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pierre d'Herbemont
Comment 1 2009-04-24 15:39:03 PDT
Created attachment 29768 [details] patch v1.
Simon Fraser (smfr)
Comment 2 2009-04-24 15:41:57 PDT
Comment on attachment 29768 [details] patch v1. > Index: LayoutTests/ChangeLog > =================================================================== > --- LayoutTests/ChangeLog (revision 42845) > +++ LayoutTests/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Fixed a race condition on the first 'played' attribute test start. > + > + Previously we were starting nearly right away to play, and probably > + before receiving the 'canplay' event. Now we ensure we'll wait for > + that 'canplay' event before attempting to play. "...before starting the tests." > waitForEvent("loadedmetadata"); > - waitForEvent("canplay", canplay); > + waitForEvent("canplay", canplay); // Will triggers nextTest() which launches the tests. "Will trigger" r=me
Simon Fraser (smfr)
Comment 3 2009-04-24 15:53:03 PDT
http://trac.webkit.org/changeset/42848
Note You need to log in before you can comment on or make changes to this bug.