RESOLVED FIXED 25378
Document InlineBox::x(),y() 
https://bugs.webkit.org/show_bug.cgi?id=25378
Summary Document InlineBox::x(),y()
Jeremy Moskovich
Reported 2009-04-24 14:48:04 PDT
The use of m_x & m_y in InlineBox and it's various inherited classes is a little confusing. Adding a comment to clear up what they represent would be helpful.
Attachments
patch (1.24 KB, patch)
2009-04-24 14:54 PDT, Jeremy Moskovich 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2009-04-24 14:54:05 PDT
Created attachment 29767 [details] patch
Eric Seidel (no email)
Comment 2 2009-04-27 17:13:13 PDT
This agrees with my understanding of InlineBox::x() and y(). Assuming Hyatt agrees, r+.
Eric Seidel (no email)
Comment 3 2009-05-04 01:52:52 PDT
Comment on attachment 29767 [details] patch Assuming Hyatt's silence is agreement.
Eric Seidel (no email)
Comment 4 2009-05-05 22:49:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/InlineBox.h Committed r43282
Note You need to log in before you can comment on or make changes to this bug.