Bug 25378 - Document InlineBox::x(),y()
Summary: Document InlineBox::x(),y()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-24 14:48 PDT by Jeremy Moskovich
Modified: 2009-05-05 22:49 PDT (History)
2 users (show)

See Also:


Attachments
patch (1.24 KB, patch)
2009-04-24 14:54 PDT, Jeremy Moskovich
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2009-04-24 14:48:04 PDT
The use of m_x & m_y in InlineBox and it's various inherited classes is a little confusing.

Adding a comment to clear up what they represent would be helpful.
Comment 1 Jeremy Moskovich 2009-04-24 14:54:05 PDT
Created attachment 29767 [details]
patch
Comment 2 Eric Seidel (no email) 2009-04-27 17:13:13 PDT
This agrees with my understanding of InlineBox::x() and y().  Assuming Hyatt agrees, r+.
Comment 3 Eric Seidel (no email) 2009-05-04 01:52:52 PDT
Comment on attachment 29767 [details]
patch

Assuming Hyatt's silence is agreement.
Comment 4 Eric Seidel (no email) 2009-05-05 22:49:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/InlineBox.h
Committed r43282