WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253758
☂️ [GTK][WPE?] GitHub breaks in different ways after their March 2023 update
https://bugs.webkit.org/show_bug.cgi?id=253758
Summary
☂️ [GTK][WPE?] GitHub breaks in different ways after their March 2023 update
antoyo
Reported
2023-03-11 08:40:32 PST
Hi. When I go to github.com with Web (Epiphany) version 43.1+, the page just stays blank and a lot of CPU is used. I'm on ArtixLinux and the version of webkit installed is 2.38.5-1. Thanks to fix this issue.
Attachments
Add attachment
proposed patch, testcase, etc.
antoyo
Comment 1
2023-03-11 12:39:20 PST
***
Bug 253760
has been marked as a duplicate of this bug. ***
antoyo
Comment 2
2023-03-11 12:39:36 PST
***
Bug 253759
has been marked as a duplicate of this bug. ***
Guilaume Ayoub
Comment 3
2023-03-11 13:53:16 PST
The problem is caused by "navigator.clipboard" missing. As a dirty workaround, I’ve used "navigator.clipboard = {}" in Epiphany’s custom JS file (available in Epiphany’s options). Note that since yesterday, some features of GitHub don’t work anymore with Epiphany (applying labels on issues is another one), and many errors are reported in the inspector. Looks like GitHub decided to drop support of many browsers…
Adrian Perez
Comment 4
2023-03-13 01:34:48 PDT
For the async clipboard API we had
bug #211979
already, so I am going to repurpose this bug report for the issue with setting labels. I hope that's okay.
Adrian Perez
Comment 5
2023-03-13 01:35:07 PDT
For the async clipboard API we had
bug #211979
already, so I am going to repurpose this bug report for the issue with setting labels. I hope that's okay.
Adrian Perez
Comment 6
2023-03-13 01:36:11 PDT
For the record, this is reproducible with the 2.39.91 release, I haven't checked on a ToT build yet, but I expect setting labels won't work there either.
Guilaume Ayoub
Comment 7
2023-03-13 02:44:11 PDT
(In reply to Adrian Perez from
comment #5
)
> For the async clipboard API we had
bug #211979
already, so I am going > to repurpose this bug report for the issue with setting labels. I hope > that's okay.
There are actually many problems with GitHub’s latest update, but as far as I can tell there are all caused by 2 missing features: - navigator.clipboard, see
bug #211979
- window.requestIdleCallback, see
bug #164193
, whose support is "under consideration" in WebKit (
https://webkit.org/status/#feature-requestidlecallback
) and available almost everywhere else (
https://caniuse.com/requestidlecallback
). There may be other ones. This bug report could track the different issues required to get GitHub working again. I suppose that workarounds exist in GitHub’s JS code to make it work with Safari.
Adrian Perez
Comment 8
2023-03-13 05:22:27 PDT
(In reply to Guilaume Ayoub from
comment #7
)
> (In reply to Adrian Perez from
comment #5
) > > For the async clipboard API we had
bug #211979
already, so I am going > > to repurpose this bug report for the issue with setting labels. I hope > > that's okay. > > There are actually many problems with GitHub’s latest update, but as far as > I can tell there are all caused by 2 missing features: > > - navigator.clipboard, see
bug #211979
> - window.requestIdleCallback, see
bug #164193
, whose support is "under > consideration" in WebKit > (
https://webkit.org/status/#feature-requestidlecallback
) and available > almost everywhere else (
https://caniuse.com/requestidlecallback
). > > There may be other ones. > > This bug report could track the different issues required to get GitHub > working again. I suppose that workarounds exist in GitHub’s JS code to make > it work with Safari.
Good idea, I have done just that, and added these two bugs as dependencies. If there are more issues related to the recent GitHub update, we can add the bugs as dependencies here as well.
Michael Catanzaro
Comment 9
2023-03-13 06:11:01 PDT
We need to understand why window.requestIdleCallback is required in Epiphany but not required in Safari. Are they doing user agent sniffing?
Jeff Fortin
Comment 10
2023-03-13 06:21:01 PDT
In the meantime Adrian also reported the issue to the WebCompat tracker at
https://github.com/webcompat/web-bugs/issues/119474
via
https://webcompat.com/issues/119474
...for the record, as it is probable some GitHub folks will get contacted over there. In case the symptom vanishes (whereas technically the webkitgtk bug remains), we will know why ;)
Michael Catanzaro
Comment 11
2023-03-13 06:29:11 PDT
The site also renders if you open the web inspector. O_O
Guilaume Ayoub
Comment 12
2023-03-13 06:55:24 PDT
(In reply to Michael Catanzaro from
comment #9
)
> We need to understand why window.requestIdleCallback is required in Epiphany > but not required in Safari. Are they doing user agent sniffing?
Using a Safari user agent string (from
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent#safari_ua_string
) doesn’t fix the problem. (In reply to Michael Catanzaro from
comment #11
)
> The site also renders if you open the web inspector. O_O
When "navigator.clipboard" is missing, there’s an endless JS loop that should prevent the website from being rendered, even if the HTML and the CSS files are already downloaded. I suppose that opening the web inspector (or just resizing the window) forces the page to be drawn at least once.
Karl Dubost
Comment 13
2023-03-13 16:23:33 PDT
A thread has also been opened on
https://github.com/orgs/community/discussions/49755
Carlos Garcia Campos
Comment 14
2023-03-16 04:10:55 PDT
Adding labels worked for me (with clipboard api patch applied, not sure it's elated).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug