in Gtk, WebKit converts some native key codes wrongly. For GDK_exclaim ('!'), no conversion so it would have keyIdentifier U+0000. For GDK_parenleft ('(') and GDK_parenright (')') will be converted into opposite key: should be '9' and '0', but is '0' and '9' respectively now.
Created attachment 29745 [details] Fix wrong key code conversion. WebCore/ChangeLog | 15 +++++++++++++++ WebCore/platform/chromium/KeyCodeConversionGtk.cpp | 5 +++-- WebCore/platform/gtk/KeyEventGtk.cpp | 5 +++-- 3 files changed, 21 insertions(+), 4 deletions(-)
Created attachment 29746 [details] Fix wrong key code conversion. WebCore/ChangeLog | 16 ++++++++++++++++ WebCore/platform/chromium/KeyCodeConversionGtk.cpp | 5 +++-- WebCore/platform/gtk/KeyEventGtk.cpp | 5 +++-- 3 files changed, 22 insertions(+), 4 deletions(-)
Comment on attachment 29746 [details] Fix wrong key code conversion. Looks good to me.
Landed in r42893