WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253572
REGRESSION(
258166@main
): WebDriver tests fail to run
https://bugs.webkit.org/show_bug.cgi?id=253572
Summary
REGRESSION(258166@main): WebDriver tests fail to run
Sam Sneddon [:gsnedders]
Reported
2023-03-08 08:47:03 PST
Currently all the WebDriver tests fail (at least internally on macOS, and I _strongly_ suspect in open source GTK/WPE). This is mostly with errors like: Tests/WebDriver/py/tests/wpt/tests/element_click/user_prompts.py:122: in test_default check_user_prompt_closed_with_exception(dialog_type, retval) Tests/WebDriver/py/tests/wpt/tests/element_click/user_prompts.py:36: in check_user_prompt_closed_with_exception session.url = inline("<input type=text>") E AttributeError: 'async_generator' object has no attribute 'url' This is caused by upgrade pytest_asyncio to 0.20.3 in
258166@main
. Per its changelog,
https://github.com/pytest-dev/pytest-asyncio/blob/v0.20.3/CHANGELOG.rst
, both 0.19 and 0.20 had breaking changes. By comparison, the vendored upstream copy (
https://github.com/web-platform-tests/wpt/tree/master/tools/third_party/pytest-asyncio
) is currently at 0.14, and that also works with Python 3.11. As a first move, which gets the internal WebDriver tests working, let's downgrade to 0.18.3.
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2023-03-08 08:52:18 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11231
EWS
Comment 2
2023-03-08 10:00:11 PST
Committed
261374@main
(572012dd3e05): <
https://commits.webkit.org/261374@main
> Reviewed commits have been landed. Closing PR #11231 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-03-08 10:01:27 PST
<
rdar://problem/106433594
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug