Bug 253533 - [SOUP] HTTP/2 status text WPTs fail on WPE and GTK
Summary: [SOUP] HTTP/2 status text WPTs fail on WPE and GTK
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 176479 253043
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-07 14:16 PST by Ben Nham
Modified: 2024-01-16 13:39 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-03-07 14:16:28 PST 
These WPTs fail when we fix the WPT test runner to actually run the H2 test cases over H2 (253043):

imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-expected.txt
imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any.worker-expected.txt
imported/w3c/web-platform-tests/xhr/status.h2.window-expected.txt

Example diff:

```
--- /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-expected.txt
+++ /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-actual.txt
@@ -1,9 +1,9 @@
 
-FAIL statusText over H2 for status 200 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 210 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 400 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 404 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 410 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 500 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 502 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
+FAIL statusText over H2 for status 200 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OK"
+FAIL statusText over H2 for status 210 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Unknown Error"
+FAIL statusText over H2 for status 400 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Bad Request"
+FAIL statusText over H2 for status 404 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Not Found"
+FAIL statusText over H2 for status 410 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Gone"
+FAIL statusText over H2 for status 500 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Internal Server Error"
+FAIL statusText over H2 for status 502 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Bad Gateway"
```
Comment 1 Ben Nham 2023-03-07 14:19:07 PST 
Looks like Joseph's fix for this issue only worked for Cocoa platforms and not for other platforms: https://github.com/WebKit/WebKit/commit/93719e196089a762755edc915cbb597f32112394