Bug 25353 - Support the back/forward/stop/refresh multimedia keys
Summary: Support the back/forward/stop/refresh multimedia keys
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-23 20:45 PDT by Benjamin Meyer
Modified: 2009-06-15 19:13 PDT (History)
1 user (show)

See Also:


Attachments
patch to fix the bug (1.52 KB, patch)
2009-04-23 20:45 PDT, Benjamin Meyer
eric: review-
Details | Formatted Diff | Diff
patch to fix the bug (2.12 KB, patch)
2009-06-15 08:08 PDT, Benjamin Meyer
manyoso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2009-04-23 20:45:12 PDT
Support the back/forward/stop/refresh multimedia keys and accept the
 event when handling backspace and shift backspace as we should.
Comment 1 Benjamin Meyer 2009-04-23 20:45:38 PDT
Created attachment 29725 [details]
patch to fix the bug
Comment 2 Eric Seidel (no email) 2009-04-29 13:16:43 PDT
Comment on attachment 29725 [details]
patch to fix the bug

This was r+'d without a ChangeLog.  Please don't do that unless you plan to land it yourself. :(
Comment 3 George Staikos 2009-04-29 14:14:44 PDT
Are you really afraid this is going to be checked in without a changelog?
Comment 4 Benjamin Meyer 2009-06-15 08:08:39 PDT
Created attachment 31290 [details]
patch to fix the bug

with prepare-changelog run
Comment 5 Eric Seidel (no email) 2009-06-15 14:54:21 PDT
(In reply to comment #3)
> Are you really afraid this is going to be checked in without a changelog?

No. :)  It's just I went to try and land it, and I couldn't easily because it didn't have a ChangeLog. :)

The ChangeLog doesn't have a link to the bug in question.  We really need to fix prepare-ChangeLog to add those for you. :)
Comment 6 Benjamin Meyer 2009-06-15 15:21:37 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > Are you really afraid this is going to be checked in without a changelog?
> 
> No. :)  It's just I went to try and land it, and I couldn't easily because it
> didn't have a ChangeLog. :)

As this was a git patch the changelog text was there to be reviewed even if it wasn't in the changelog file, I didn't write a changelog, just ran the script to create it for the second patch.
Comment 7 Eric Seidel (no email) 2009-06-15 19:13:46 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/qt/Api/qwebpage.cpp
	M	WebKit/qt/ChangeLog
Committed r44704
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/Api/qwebpage.cpp
r44704 = cfd7be9b10bab318302b163d42d971858c6e87f8 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk