Bug 25351 - Enable copying image to the clipboard
Summary: Enable copying image to the clipboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-04-23 17:06 PDT by Gustavo Noronha (kov)
Modified: 2009-05-20 07:52 PDT (History)
0 users

See Also:


Attachments
enable copying image to clipboard (1.54 KB, patch)
2009-04-23 17:07 PDT, Gustavo Noronha (kov)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-04-23 17:06:32 PDT
Now that we have a way to turn images to GdkPixbuf's, we can enable the code that is commented out in PasteBoardGtk
Comment 1 Gustavo Noronha (kov) 2009-04-23 17:07:57 PDT
Created attachment 29719 [details]
enable copying image to clipboard
Comment 2 Eric Seidel (no email) 2009-04-27 17:14:02 PDT
Comment on attachment 29719 [details]
enable copying image to clipboard

Looks wrong.  Why is it OK to ASSERT here in the gtk version and not in the mac version?
Comment 3 Gustavo Noronha (kov) 2009-05-04 16:46:10 PDT
Comment on attachment 29719 [details]
enable copying image to clipboard

(In reply to comment #2)
> (From update of attachment 29719 [details] [review])
> Looks wrong.  Why is it OK to ASSERT here in the gtk version and not in the mac
> version?

From my reading of the code, the same ASSERT's exist in Mac. Am I missing something?:

void Pasteboard::writeImage(Node* node, const KURL& url, const String& title)
{
    ASSERT(node);
[...]
    ASSERT(node->renderer() && node->renderer()->isImage());
[...]
    ASSERT(cachedImage);
[...]
    ASSERT(image);
[...]
}
Comment 4 Eric Seidel (no email) 2009-05-19 19:38:04 PDT
Comment on attachment 29719 [details]
enable copying image to clipboard

Shrugs.  rs=me
Comment 5 Gustavo Noronha (kov) 2009-05-20 07:52:17 PDT
Landed as r43909, thanks Eric =).