Bug 25342 - Pass MessageLevel and MessageSource into the ChromeClient::addMessageToConsole
: Pass MessageLevel and MessageSource into the ChromeClient::addMessageToConsole
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-04-23 07:41 PST by
Modified: 2009-04-30 09:41 PST (History)


Attachments
patch (12.35 KB, patch)
2009-04-23 07:41 PST, Pavel Feldman
eric: review-
Review Patch | Details | Formatted Diff | Diff
patch (12.93 KB, patch)
2009-04-30 09:03 PST, Pavel Feldman
dglazkov: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-04-23 07:41:02 PST
Pass MessageLevel and MessageSource into the ChromeClient::addMessageToConsole
------- Comment #1 From 2009-04-23 07:41:46 PST -------
Created an attachment (id=29710) [details]
patch
------- Comment #2 From 2009-04-23 08:27:13 PST -------
Adding Timothy to CC. BTW, you don't need to remove "Reviewed by NOBODY (OOPS!)" from the ChangeLog.
------- Comment #3 From 2009-04-23 09:16:38 PST -------
(From update of attachment 29710 [details])
Patch looks fine. But why is this needed?
------- Comment #4 From 2009-04-23 12:18:07 PST -------
(In reply to comment #3)
> (From update of attachment 29710 [details] [review])
> Patch looks fine. But why is this needed?
> 

Hm.. I thought I replied to this one. Anyway, posting again.

Our async/out-of-process version of WebInspector is currently not based on InspectorController. The reason was that we did not want to interfere with Dmitry's unforking effort, yet wanted to experiment. So we came up with these agents concept that basically mimic InspectorController, but separating 'agent' nature from the 'transport'. Now that InspectorController is unforked, I am planning to bring these concepts into the WebKit land and use what we have in Chromium as a proof of concept / experimental playground.

It will take me some time to split InspectorController and I don't want Chromium guys to be blocked by that. Hence I want to expose events that are missing in clients, namely: console severity and xmlhttprequest data. I realize that this is somewhat a temporary measure, but I think it will serve us all well.

Does it make sence?
------- Comment #5 From 2009-04-23 12:29:39 PST -------
Yes, makes sense. It would be good to give a brief reason when posting patches so we don't have to ask/wonder. Thanks for explaining!
------- Comment #6 From 2009-04-29 13:17:41 PST -------
(From update of attachment 29710 [details])
Please update the patch to include the nice comments you discussed with Timonthy.  That way someone else can land it w/o thinking about it.
------- Comment #7 From 2009-04-30 09:03:54 PST -------
Created an attachment (id=29913) [details]
patch
------- Comment #8 From 2009-04-30 09:04:11 PST -------
(In reply to comment #6)
> (From update of attachment 29710 [details] [review])
> Please update the patch to include the nice comments you discussed with
> Timonthy.  That way someone else can land it w/o thinking about it.
> 

Done
------- Comment #9 From 2009-04-30 09:24:40 PST -------
(From update of attachment 29913 [details])
Don't forget a URL in the ChangeLog. But I'll fix up and land shortly.
------- Comment #10 From 2009-04-30 09:41:46 PST -------
Landed as http://trac.webkit.org/changeset/43063.