NEW 253417
Remove extra call to 'layout' in Document::setParsing 
https://bugs.webkit.org/show_bug.cgi?id=253417
Summary Remove extra call to 'layout' in Document::setParsing
Ahmad Saleem
Reported 2023-03-05 15:02:50 PST
Hi Team, While going through Blink's commit - I came across following, where we also have FIXME to rename function of similar: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/56ef94099e79af642ee0ef5a3c8a3523c1ecc7dc WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/Document.h#2319 etc. ^ There is FIXME as well in WebKit Source. Do we need to merge this or come-up with better name? Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-03-06 07:10:16 PST
It looks like at this point this merge would only including the renaming part (WebKit does not schedule layout inside Document::setParsing)
Ahmad Saleem
Comment 2 2023-03-06 07:33:45 PST
(In reply to zalan from comment #1) > It looks like at this point this merge would only including the renaming > part (WebKit does not schedule layout inside Document::setParsing) fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'? Just from reading the code, it seems to be "Milestone" related something.
alan
Comment 3 2023-03-06 07:35:44 PST
(In reply to Ahmad Saleem from comment #2) > (In reply to zalan from comment #1) > > It looks like at this point this merge would only including the renaming > > part (WebKit does not schedule layout inside Document::setParsing) > > fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'? No, it is not supposed to.
Ahmad Saleem
Comment 4 2023-03-06 07:36:53 PST
(In reply to zalan from comment #3) > (In reply to Ahmad Saleem from comment #2) > > (In reply to zalan from comment #1) > > > It looks like at this point this merge would only including the renaming > > > part (WebKit does not schedule layout inside Document::setParsing) > > > > fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'? > No, it is not supposed to. Should I do PR for renaming purposes and get rid of FIXME, at least one less FIXME. As long as you are OK with 'm_isParsing' name instead of 'm_bParsing'?
alan
Comment 5 2023-03-06 07:37:50 PST
sounds good!
Radar WebKit Bug Importer
Comment 6 2023-03-12 16:03:16 PDT
<rdar://problem/106621886>
Note You need to log in before you can comment on or make changes to this bug.