WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253377
Switch from WTF::Span to std::span
https://bugs.webkit.org/show_bug.cgi?id=253377
Summary
Switch from WTF::Span to std::span
David Kilzer (:ddkilzer)
Reported
2023-03-03 20:54:54 PST
Switch from WTF::Span to std::span. Now that Apple's ports of WebKit are building with C++20, it can use std::span. <
rdar://103182220
>
Attachments
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2023-03-03 21:24:12 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11058
EWS
Comment 2
2023-03-04 21:15:56 PST
Committed
261239@main
(6d41b0f74b61): <
https://commits.webkit.org/261239@main
> Reviewed commits have been landed. Closing PR #11058 and removing active labels.
Diego Pino
Comment 3
2023-03-05 22:11:09 PST
After this patch landed, WebKitGTK Debian Stable bot started failing with the following error: ``` ../../Source/WebKit/Platform/IPC/StreamConnectionBuffer.h: In static member function ‘static constexpr size_t IPC::StreamConnectionBuffer::headerSize()’: ../../Source/WebKit/Platform/IPC/StreamConnectionBuffer.h:140:84: error: ‘max_align_t’ is not a member of ‘std’; did you mean ‘max_align_t’? 140 | static constexpr size_t headerSize() { return roundUpToMultipleOf<alignof(std::max_align_t)>(sizeof(Header)); } | ^~~~~~~~~~~ In file included from /usr/include/c++/10/bits/cxxabi_init_exception.h:38, from /usr/include/c++/10/bits/exception_ptr.h:38, from /usr/include/c++/10/exception:147, from /usr/include/c++/10/new:41, from /usr/include/c++/10/bits/stl_iterator.h:81, from /usr/include/c++/10/bits/stl_algobase.h:67, from /usr/include/c++/10/algorithm:61, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-Stable-Build/build/Source/WebKit/WebKit2Prefix.h:60, from <command-line>: /usr/lib/gcc/x86_64-linux-gnu/10/include/stddef.h:426:3: note: ‘max_align_t’ declared here 426 | } max_align_t; ```
Diego Pino
Comment 4
2023-03-05 22:12:01 PST
https://build.webkit.org/#/builders/46/builds/26711/steps/9/logs/stdio
Diego Pino
Comment 5
2023-03-05 22:12:49 PST
Re-opening for pull request
https://github.com/webkit/webkit/pull/11097
EWS
Comment 6
2023-03-05 22:42:50 PST
Committed
261255@main
(d4e7ec025851): <
https://commits.webkit.org/261255@main
> Reviewed commits have been landed. Closing PR #11097 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug