Bug 253373 – AX: Standalone spin buttons should be directly incrementable and decrementable

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Standalone spin buttons should be directly incrementable and decrementable.

[Radar WebKit Bug Importer]

<rdar://problem/106224266>

[Tyler Wilcock]

Created attachment 465288 [details]
Patch

[Tyler Wilcock]

Created attachment 465293 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Created attachment 465293 [details]
> Patch

Concerning the naming, can we use something like "simple" vs. "composite" instead of IncrementDecrement?

Could we expose all spinbuttons as "simple"? i.e., why do we need to expose the separate increment and decrement buttons?

[Tyler Wilcock]

(In reply to Andres Gonzalez from comment #4)
> (In reply to Tyler Wilcock from comment #3)
> > Created attachment 465293 [details]
> > Patch
> 
> Concerning the naming, can we use something like "simple" vs. "composite"
> instead of IncrementDecrement?
Composite is a good name, thanks. I think I like "standalone" over "simple" as it's more descriptive and a better analogy to "composite".

> Could we expose all spinbuttons as "simple"? i.e., why do we need to expose
> the separate increment and decrement buttons?
VoiceOver would handle the removal of these separate increment and decrement buttons just fine as long as the spinbutton itself exposes the increment and decrement actions. However, AppKit accessibility may expect attributes to be exposed for these separate spinbutton controls. I think we should explore whether we really need these attributes in a future patch.

[Tyler Wilcock]

Created attachment 465351 [details]
Patch

[Tyler Wilcock]

Created attachment 465353 [details]
Patch

[EWS]

Committed 261396@main (71206def1a57): <https://commits.webkit.org/261396@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465353 [details].