WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
25337
Move ThreadingQt.cpp under the qt directory.
https://bugs.webkit.org/show_bug.cgi?id=25337
Summary
Move ThreadingQt.cpp under the qt directory.
Laszlo Gombos
Reported
2009-04-22 21:18:55 PDT
JavaScriptCore/wtf/ThreadingQt.cpp should be under JavaScriptCore/wtf/qt/ThreadingQt.cpp to be consistent with the rest of the source tree structure. Separate bugs will be created for other port specific Threading files (Win, Gtk).
Attachments
Move ThreadingQt.cpp under the qt directory.
(15.89 KB, patch)
2009-04-22 21:28 PDT
,
Laszlo Gombos
mrowe
: review-
Details
Formatted Diff
Diff
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory.
(15.30 KB, patch)
2009-04-23 05:45 PDT
,
Laszlo Gombos
mrowe
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2009-04-22 21:28:58 PDT
Created
attachment 29705
[details]
Move ThreadingQt.cpp under the qt directory. Also enable Qt builds without threading support when ENABLE_THREADS is set to 0.
Mark Rowe (bdash)
Comment 2
2009-04-22 23:04:27 PDT
Comment on
attachment 29705
[details]
Move ThreadingQt.cpp under the qt directory. This patch does two completely unrelated things.
Laszlo Gombos
Comment 3
2009-04-23 05:45:01 PDT
Created
attachment 29709
[details]
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory.
Mark Rowe (bdash)
Comment 4
2009-04-23 14:16:36 PDT
Comment on
attachment 29709
[details]
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory. rs=me
Jan Alonzo
Comment 5
2009-04-24 17:28:21 PDT
(In reply to
comment #4
)
> (From update of
attachment 29709
[details]
[review]) > rs=me >
Landed in
r42858
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug