Bug 25337 - Move ThreadingQt.cpp under the qt directory.
Summary: Move ThreadingQt.cpp under the qt directory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 21:18 PDT by Laszlo Gombos
Modified: 2009-04-24 17:28 PDT (History)
0 users

See Also:


Attachments
Move ThreadingQt.cpp under the qt directory. (15.89 KB, patch)
2009-04-22 21:28 PDT, Laszlo Gombos
mrowe: review-
Details | Formatted Diff | Diff
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory. (15.30 KB, patch)
2009-04-23 05:45 PDT, Laszlo Gombos
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-04-22 21:18:55 PDT
JavaScriptCore/wtf/ThreadingQt.cpp should be under JavaScriptCore/wtf/qt/ThreadingQt.cpp to be consistent with the rest of the source tree structure. Separate bugs will be created for other port specific Threading files (Win, Gtk).
Comment 1 Laszlo Gombos 2009-04-22 21:28:58 PDT
Created attachment 29705 [details]
Move ThreadingQt.cpp under the qt directory. 

Also enable Qt builds without threading support when ENABLE_THREADS is set to 0.
Comment 2 Mark Rowe (bdash) 2009-04-22 23:04:27 PDT
Comment on attachment 29705 [details]
Move ThreadingQt.cpp under the qt directory. 

This patch does two completely unrelated things.
Comment 3 Laszlo Gombos 2009-04-23 05:45:01 PDT
Created attachment 29709 [details]
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory.
Comment 4 Mark Rowe (bdash) 2009-04-23 14:16:36 PDT
Comment on attachment 29709 [details]
Do one thing and do it well. Move ThreadingQt.cpp under the qt directory.

rs=me
Comment 5 Jan Alonzo 2009-04-24 17:28:21 PDT
(In reply to comment #4)
> (From update of attachment 29709 [details] [review])
> rs=me
> 

Landed in r42858