Bug 253354 - [git-webkit] Add pre-push hook to prevent publication of security sensitive commits
Summary: [git-webkit] Add pre-push hook to prevent publication of security sensitive c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-03 16:06 PST by Jonathan Bedard
Modified: 2023-09-21 14:51 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-03 16:06:27 PST
We should have a pre-push hook that makes it difficult for contributors to push content we know contains security sensative changes. We have 3 ways of knowing this: 1) The commit a user is trying to push already exists on a different remote with a higher secuirty level than the target remote 2) The commit a user is pushing is a cherry-pick of a commit that already exists on a different remote with a higher security level than the target remote 3) The commit being pushed references a security issue. In most circumstances, we should outright block the first case and prompt the user for cases 2 and 3. The 'git-webkit publish' workflow should prompt the user in the first case, but block cases 2 and 3.
Comment 1 Radar WebKit Bug Importer 2023-03-03 16:06:50 PST
<rdar://problem/106216593>
Comment 2 Jonathan Bedard 2023-03-03 16:38:24 PST
Pull request: https://github.com/WebKit/WebKit/pull/11043
Comment 3 EWS 2023-03-10 13:18:30 PST
Committed 261526@main (604395a516c1): <https://commits.webkit.org/261526@main>

Reviewed commits have been landed. Closing PR #11043 and removing active labels.
Comment 4 EWS 2023-03-14 10:25:51 PDT
Committed 259548.415@safari-7615-branch (16c7018215b7): <https://commits.webkit.org/259548.415@safari-7615-branch>

Reviewed commits have been landed. Closing PR #456 and removing active labels.
Comment 5 Jonathan Bedard 2023-03-17 08:07:47 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11652
Comment 6 EWS 2023-03-17 08:46:34 PDT
Committed 261794@main (e52330471c00): <https://commits.webkit.org/261794@main>

Reviewed commits have been landed. Closing PR #11652 and removing active labels.
Comment 7 EWS 2023-03-17 11:26:24 PDT
Committed 259548.445@safari-7615-branch (539dd07a827f): <https://commits.webkit.org/259548.445@safari-7615-branch>

Reviewed commits have been landed. Closing PR #478 and removing active labels.