RESOLVED FIXED253348
Use smart pointers for PageConfiguration 
https://bugs.webkit.org/show_bug.cgi?id=253348
Summary Use smart pointers for PageConfiguration
Alex Christensen
Reported 2023-03-03 15:10:05 PST
...
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-03 15:10:19 PST
<rdar://problem/106214366>
Alex Christensen
Comment 2 2023-03-03 15:19:16 PST
Pull request: https://github.com/WebKit/WebKit/pull/11033
EWS
Comment 3 2023-03-04 09:35:47 PST
Committed 261225@main (c4ee0780b398): <https://commits.webkit.org/261225@main> Reviewed commits have been landed. Closing PR #11033 and removing active labels.
Diego Pino
Comment 4 2023-03-06 19:15:01 PST
After this patch, I'm getting the following build error in WinCairo: ``` 57>WebPage.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl WebKit::WebChromeClient::~WebChromeClient(void)" (??1WebChromeClient@WebKit@@UEAA@XZ) referenced in function "public: virtual void * __cdecl WebKit::WebChromeClient::`scalar deleting destructor'(unsigned int)" (??_GWebChromeClient@WebKit@@UEAAPEAXI@Z) ``` Apparently WinCairo build bot hasn't detected this build error. https://build.webkit.org/#/builders/731 I'm doing a clean build. I wonder whether a clean build in the CI bot may trigger the issue. My environment is: - OS: Windows10. - Compiler: Microsoft Visual Studio 2022.
Diego Pino
Comment 5 2023-03-06 19:18:25 PST
Re-opening for pull request https://github.com/webkit/webkit/pull/11148
EWS
Comment 6 2023-03-07 09:05:37 PST
Committed 261327@main (89cc5666c25a): <https://commits.webkit.org/261327@main> Reviewed commits have been landed. Closing PR #11148 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.