Bug 25329 - v8 binding of ClientRectList doesn't have indexed access method
Summary: v8 binding of ClientRectList doesn't have indexed access method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Fumitoshi Ukai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 12:32 PDT by Fumitoshi Ukai
Modified: 2014-04-24 16:45 PDT (History)
0 users

See Also:


Attachments
Add V8ClientRectListCustom.cpp (3.00 KB, patch)
2009-04-22 16:19 PDT, Fumitoshi Ukai
dglazkov: review+
Details | Formatted Diff | Diff
Add V8ClientRectListCustom.cpp (3.00 KB, patch)
2009-04-22 16:48 PDT, Fumitoshi Ukai
no flags Details | Formatted Diff | Diff
add bug URL in ChangeLog (453 bytes, patch)
2009-04-22 16:48 PDT, Fumitoshi Ukai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-04-22 12:32:30 PDT
v8 binding of ClientRectList doesn't have indexed access method.

For example, on translate.google.com chromium doesn't show balloon because of the following code throws JavaScript exception.

  p = a.getClientRects(); ... ; ... p[0].top  // p[0] is undefined in chromium

According to CSSOM View Module spec, ClientRectList must provide indexed access method that acts like item() method.
http://dev.w3.org/csswg/cssom-view/#clientrectlist
Comment 1 Fumitoshi Ukai 2009-04-22 16:19:43 PDT
Created attachment 29695 [details]
Add V8ClientRectListCustom.cpp

 WebCore/ChangeLog                                  |    9 +++
 .../bindings/v8/custom/V8ClientRectListCustom.cpp  |   55 ++++++++++++++++++++
 2 files changed, 64 insertions(+), 0 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-04-22 16:42:44 PDT
Comment on attachment 29695 [details]
Add V8ClientRectListCustom.cpp

Looks good, except for:

Add Bug URL (https://bugs.webkit.org/show_bug.cgi?id=25329) here..
> +        Add indexed access method in v8 binding of ClientRectList.
> +
> +        * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
> +        (WebCore::INDEXED_PROPERTY_GETTER):
Comment 3 Fumitoshi Ukai 2009-04-22 16:48:44 PDT
Created attachment 29696 [details]
Add V8ClientRectListCustom.cpp

 WebCore/ChangeLog                                  |    9 +++
 .../bindings/v8/custom/V8ClientRectListCustom.cpp  |   55 ++++++++++++++++++++
 2 files changed, 64 insertions(+), 0 deletions(-)
Comment 4 Fumitoshi Ukai 2009-04-22 16:48:46 PDT
Created attachment 29697 [details]
add bug URL in ChangeLog

 WebCore/ChangeLog |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Comment 5 Dimitri Glazkov (Google) 2009-04-24 11:36:45 PDT
Landed as http://trac.webkit.org/changeset/42829.
Comment 6 Darin Adler 2014-04-24 16:45:01 PDT
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.