Bug 253209 - AX: Enhanced Accessibility Mode breaks arrow-key scrolling for non-VoiceOver users
Summary: AX: Enhanced Accessibility Mode breaks arrow-key scrolling for non-VoiceOver ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 16
Hardware: Mac (Apple Silicon) Other
: P2 Major
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-01 17:29 PST by Cooper Barth
Modified: 2023-04-13 11:29 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2023-03-01 17:44 PST, Cooper Barth 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cooper Barth 2023-03-01 17:29:50 PST 
Enhanced Accessibility Mode breaks arrow-key scrolling for non-VoiceOver users.
Comment 1 Radar WebKit Bug Importer 2023-03-01 17:30:00 PST 
<rdar://problem/106115785>
Comment 2 Cooper Barth 2023-03-01 17:44:09 PST 
Created attachment 465253 [details]
Patch
Comment 3 Tommy McHugh 2023-03-01 17:50:30 PST 
I am slightly concerned about not doing this for FKA given the similar AX model between it and VO
Comment 4 chris fleizach 2023-03-01 19:02:00 PST 
Comment on attachment 465253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465253&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:224
> +    if (flag && client == kAXClientTypeVoiceOver)

This is an SPI that expects to be set. This will break that SPI

Also isn’t VO already setting this?
Comment 5 Cooper Barth 2023-03-03 15:38:51 PST 
After some further investigation, agreed that this patch likely isn't the correct fix, seeing as we do need to enter AssistiveControl to enter Enhanced Accessibility Mode for other non-scrolling related functionality.

A likely better fix would be to modify Enhanced Accessibility Mode to only disable scrolling if the client is VoiceOver. Ongoing discussion with the team as to whether this behavior should be enabled for Full Keyboard Access as well.
Comment 6 Cooper Barth 2023-04-13 11:29:26 PDT 
Moving this to do not fix - we're making a change on our end to resolve the issue.