Bug 253180 - [GTK][WPE] Remote Web Inspector: replace deprecated CSS method 'matches' with 'is'
Summary: [GTK][WPE] Remote Web Inspector: replace deprecated CSS method 'matches' with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Przemyslaw Gorszkowski
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-01 11:31 PST by Przemyslaw Gorszkowski
Modified: 2023-03-06 02:44 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Gorszkowski 2023-03-01 11:31:09 PST 
The :matches()selector was renamed to :is() in https://github.com/w3c/csswg-drafts/issues/3258

:matches() is no longer supported by some browsers (like Chromium and Firefox) and breaks Web Inspector UI in such browsers when we connect via HTTP.

In case GTK/WPE WebKit, we use HTTP version of the inspector and it can be used from any browser.

In Firefox we get warning:
"Unknown pseudo-class or pseudo-element ‘matches’.  Ruleset ignored due to bad selector"
Comment 1 Przemyslaw Gorszkowski 2023-03-02 02:08:25 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10927
Comment 2 EWS 2023-03-06 02:43:29 PST 
Committed 261264@main (1e4c1a8d21b7): <https://commits.webkit.org/261264@main>

Reviewed commits have been landed. Closing PR #10927 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-06 02:44:16 PST 
<rdar://problem/106280337>