Bug 253164 – REGRESSION(254273@main): wptserve causes "accept incoming network connections?" prompt

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

As of the past ~while, run-webkit-tests triggers a bunch of prompts like:

> Do you want the application "Python.app" to accept incoming network connections?
>
> Clicking Deny may limit the application's behavior. This setting can be changed in the Firewall pane of Network Settings.

This is caused by wptserve not binding properly to localhost, which wouldn't cause these prompts to occur.

[Radar WebKit Bug Importer]

<rdar://problem/106090605>

[Sam Sneddon [:gsnedders]]

Oh! This is probably caused by https://github.com/web-platform-tests/wpt/commit/24da741d3c5bba4110f590c1faf771596d543482 (me, 2018), and then at some point later the aliasing was removed.

[Sam Sneddon [:gsnedders]]

Hmm, no: the aliasing is still there.

[Sam Sneddon [:gsnedders]]

Ah: https://github.com/WebKit/WebKit/commit/a5f5fb99a72b67a94407f34c4ab2b76b5bbcbc04#diff-2a84c466417fda744dd91db26cacfdab891060322040874333ad0f2d6314eea7 changed the config:

- "bind_hostname": true,
+ "bind_address": false,

Patrick: I'm not sure why this is needed, especially given Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py also now creates a config with the right set of hosts?

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/12241

[EWS]

Committed 262821@main (67e2dc7878b6): <https://commits.webkit.org/262821@main>

Reviewed commits have been landed. Closing PR #12241 and removing active labels.