Bug 253145 - REGRESSION(254676@main): [GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers
Summary: REGRESSION(254676@main): [GTK][WPE] Remote Web Inspector: the remote inspecto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Przemyslaw Gorszkowski
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-01 03:02 PST by Przemyslaw Gorszkowski
Modified: 2023-03-02 01:41 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Gorszkowski 2023-03-01 03:02:00 PST 
If I try to connect to webkit(gtk/wpe) from any browser(chrome, ff, webkitgtk-minibrowser) it display empty site. By inspect inspector site there is error:

typeerror: InspectorFrontendHost.engineeringSettingsAllowed is not a function. (In 'InspectorFrontendHost.engineeringSettingsAllowed()', 'InspectorFrontendHost.engineeringSettingsAllowed' is undefined)

It is a regression after https://github.com/WebKit/WebKit/commit/2326b1146886546de0d44f6aa85415b2e1257b8a

The missing function has to be added to: Source/WebInspectorUI/UserInterface/Base/BrowserInspectorFrontendHost.js to fix this error.

Reproduction step:
1. open any site via minibrowser:
WEBKIT_INSPECTOR_HTTP_SERVER="127.0.0.1:9225" Tools/Scripts/run-minibrowser --gtk --release http://www.igalia.com
2. try to connect to is via remote inspector(firefox, chrome, minibrowser)
Tools/Scripts/run-minibrowser --gtk --release http://127.0.0.1:9225

Inspector site is empty and there is error in inspector:
typeerror: InspectorFrontendHost.engineeringSettingsAllowed is not a function. (In 'InspectorFrontendHost.engineeringSettingsAllowed()', 'InspectorFrontendHost.engineeringSettingsAllowed' is undefined)
Comment 1 Przemyslaw Gorszkowski 2023-03-01 03:16:38 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10857
Comment 2 EWS 2023-03-02 01:40:28 PST 
Committed 261056@main (1506a7bfdb72): <https://commits.webkit.org/261056@main>

Reviewed commits have been landed. Closing PR #10857 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-02 01:41:14 PST 
<rdar://problem/106133407>