Bug 253133 - memory pressure handler should call deleteAllCode with PreventCollectionAndDeleteAllCode
Summary: memory pressure handler should call deleteAllCode with PreventCollectionAndDe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-28 19:43 PST by Cameron McCormack (:heycam)
Modified: 2023-03-02 03:48 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2023-02-28 19:43:54 PST 
The memory pressure handler currently calls GCController::deleteAllCode(DeleteAllCodeIfNotCollecting), but it turns out we hit the case of a collection being in progress moderately often.  We already do a bunch of blocky work here to get memory usage down, so let's change this to PreventCollectionAndDeleteAllCode to guarantee we can drop all JIT code.
Comment 1 Radar WebKit Bug Importer 2023-02-28 19:44:21 PST 
<rdar://problem/106065668>
Comment 2 Cameron McCormack (:heycam) 2023-02-28 19:47:01 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10847
Comment 3 EWS 2023-03-02 03:48:39 PST 
Committed 261061@main (69098ebe6b1e): <https://commits.webkit.org/261061@main>

Reviewed commits have been landed. Closing PR #10847 and removing active labels.