I've cleaned up some of the V8 bindings to use AtomicStrings better, making sure we don't covert strings more than we have to.
Created attachment 29648 [details] Fix
Comment on attachment 29648 [details] Fix > Index: bindings/v8/V8Binding.h > =================================================================== > --- bindings/v8/V8Binding.h (revision 42710) > +++ bindings/v8/V8Binding.h (working copy) > @@ -34,7 +34,7 @@ > // FIXME: This is a temporary forwarding header until all bindings have migrated > // over and v8_binding actually becomes V8Binding. > #include "v8_binding.h" > - > +#include "AtomicString.h" > namespace WebCore { > > // FIXME: Remove once migration is complete. > @@ -51,7 +51,13 @@ namespace WebCore { > // FIXME: Remove once migration is complete. > inline String toWebCoreString(v8::Handle<v8::Value> obj) > { > - return ToWebCoreString(obj); > + return ToWebCoreString(obj); > + } > + > + // FIXME: Remove once migration is complete. > + inline String toWebCoreString(v8::Handle<v8::String> obj) > + { > + return ToWebCoreString(obj); > } Did you mean to put this file into this change? It's just reformatting to 2-space indent, which ain't good for WebKit anyway. Otherwise, looks good.
Created attachment 29652 [details] Fix
You're right...I removed the file from the patch.
Landed as http://trac.webkit.org/changeset/42714.