Bug 25308 - REGRESSION (r42182): Build fails after following build instructions on webkit.org fail when using VC++ Express
Summary: REGRESSION (r42182): Build fails after following build instructions on webkit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2009-04-21 08:22 PDT by Adam Roben (:aroben)
Modified: 2009-05-05 08:58 PDT (History)
1 user (show)

See Also:

Attachments
patch + changelog v1 (3.12 KB, patch)
2009-05-05 08:28 PDT, Adam Roben (:aroben) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-04-21 08:22:10 PDT 
r42182 changed build-webkit to invoke pdevenv instead of invoking Visual Studio or VC++ Express directly. But this has caused the build to fail when following the build instructions on webkit.org and using VC++ Express. The build fails because windows.h cannot be found. Presumably this is because pdevenv passes the /useenv switch to VC++ Express, and this causes VC++ Express to ignore the Platform SDK paths that were added to it as part of the build instructions.
Comment 1 Adam Roben (:aroben) 2009-05-05 08:28:09 PDT 
Created attachment 30020 [details]
patch + changelog v1
Comment 2 Eric Seidel (no email) 2009-05-05 08:29:18 PDT 
Comment on attachment 30020 [details]
patch + changelog v1

I'm not really an expert here, but this looks sane enough to me.
Comment 3 Adam Roben (:aroben) 2009-05-05 08:58:56 PDT 
Landed as r43239