WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253066
[webkitcorepy] AutoInstall unable to install pytest-asyncio (or other packages without setup.py)
https://bugs.webkit.org/show_bug.cgi?id=253066
Summary
[webkitcorepy] AutoInstall unable to install pytest-asyncio (or other package...
Sam Sneddon [:gsnedders]
Reported
2023-02-28 02:54:37 PST
258166@main
(
bug 249564
) updated the AutoInstalled versions of pytest and its plugins, including pytest-asyncio. pytest-asyncio, as of 0.19, no longer includes a setup.py: it relies on the build frontend reading pyproject.toml, per PEP 517 (
https://peps.python.org/pep-0517/
). However, the AutoInstall has no knowledge of PEP 517, and instead tries to run a setup.py, and falls back to just copying the whole source packages over and hoping for the best. This (unsurprisingly) doesn't work well.
Attachments
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2023-03-01 10:50:53 PST
Looks like pytest-asyncio includes a setup.cfg, so it's note entirely in a world with only pyproject.toml yet. We also would need to bump our setuptools version to support pyproject.toml, which I'm not against in the long term, but I think needs a tad more validation. Fixing pytest-asyncio, however, doesn't require bumping setuptools. It just requires laying down a dummy setup.py file which picks up setup.cfg through setuptools. We don't even have to touch our invocation of setup.py, which is actually somewhat surprising.
Radar WebKit Bug Importer
Comment 2
2023-03-01 10:53:00 PST
<
rdar://problem/106095209
>
Jonathan Bedard
Comment 3
2023-03-01 10:56:09 PST
Pull request:
https://github.com/WebKit/WebKit/pull/10880
EWS
Comment 4
2023-03-02 13:51:20 PST
Committed
261097@main
(752a2873e756): <
https://commits.webkit.org/261097@main
> Reviewed commits have been landed. Closing PR #10880 and removing active labels.
EWS
Comment 5
2023-03-02 16:46:15 PST
Committed
259548.354@safari-7615-branch
(c2279007a3a5): <
https://commits.webkit.org/259548.354@safari-7615-branch
> Reviewed commits have been landed. Closing PR #431 and removing active labels.
Fujii Hironori
Comment 6
2023-03-05 17:41:33 PST
Regressed:
Bug 253421
– REGRESSION(
261097@main
) [Win] test-webkitpy: Failed to install pytest-asyncio-0.20.3!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug