Bug 253064 - ImageBufferBackend has functions marked as const when they are not that in practice
Summary: ImageBufferBackend has functions marked as const when they are not that in pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-28 01:01 PST by Kimmo Kinnunen
Modified: 2023-03-01 00:30 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-02-28 01:01:11 PST 
ImageBufferBackend has functions marked as const when they are not that in practice

The object is expected to hold caches and do lazy instantiation. It's not useful to mark the abstract methods const with these expectations.
Comment 1 Radar WebKit Bug Importer 2023-02-28 01:01:36 PST 
<rdar://problem/106020570>
Comment 2 Kimmo Kinnunen 2023-02-28 01:04:50 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10786
Comment 3 EWS 2023-03-01 00:30:34 PST 
Committed 260988@main (fc59b09d8313): <https://commits.webkit.org/260988@main>

Reviewed commits have been landed. Closing PR #10786 and removing active labels.