Bug 25302 – svg/custom/svg-fonts-in-text-controls.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ojan Vafai]

Need to make sure that a layout happens before we measure the elements in this test and that we do the measuring on load, not before. In order to make this happen, we need to give js-test-pre/post.js waitUntilDone functionality. Patch forthcoming...

[Ojan Vafai]

Created attachment 29626 [details]
Fix svg/custom/svg-fonts-in-text-controls-expected.txt and add waitUntilDone support to js-test-pre/post.js.

 6 files changed, 65 insertions(+), 9 deletions(-)

[Ojan Vafai]

This is a proposed patch. Somehow this cases 3 other tests to fail in ways I don't get. But, while I look into that, I'd like feedback on the general approach.

[Ojan Vafai]

Created attachment 29627 [details]
Fix svg/custom/svg-fonts-in-text-controls-expected.txt and add waitUntilDone support to js-test-pre/post.js.

 6 files changed, 65 insertions(+), 9 deletions(-)

DRT does not dump before the load event fires, so I don't understand why explicit waitUntilDone/notifyDone are required

[Eric Seidel (no email)]

(In reply to comment #4)
> DRT does not dump before the load event fires, so I don't understand why
> explicit waitUntilDone/notifyDone are required

Interesting.  I wonder if this is a "recent" improvement in DRT (in the last few years)... I don't remember it used to working that way.

[Ojan Vafai]

OK. I am more and more convinced that the proper fix is to
a) do the successfullyParsed check at window load time.
b) add a way to have waitUntilDone/notifyDone work properly with JS tests.

In order to fix this test, I'd need to do both A and B because A causes the svg/dynamic-updates tests to fail and the fix to their failures is to do B.

In short, I'm just going to commit a new set of results for svg-fonts-in-text-controls.html that has the success messages in the wrong order for now to get the tree green. Then I'll work on the proper fix after.

[Ojan Vafai]

Created attachment 29631 [details]
Fix svg-fonts-in-text-controls.js

 2 files changed, 11 insertions(+), 4 deletions(-)

[Ojan Vafai]

Created attachment 29632 [details]
Fix svg-fonts-in-text-controls.js

 3 files changed, 29 insertions(+), 4 deletions(-)

[Ojan Vafai]

Created attachment 29633 [details]
Fix svg-fonts-in-text-controls.js

 3 files changed, 29 insertions(+), 4 deletions(-)

[Ojan Vafai]

Created attachment 29634 [details]
Fix svg-fonts-in-text-controls.js

 3 files changed, 29 insertions(+), 4 deletions(-)

[Ojan Vafai]

eseidel r+'ed this in person, but had to run. Can someone commit this for me so the tree can go green?

[David Levin]

Working on landing.

[David Levin]

Committed <http://trac.webkit.org/changeset/42690>