Bug 25300 – microsoft virtual earth overlay error

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Corey Mitchell]

Create an overlay on the map (collections > add pushpin).  Move the pushpin.  

Error: javascript://pushin%20hover (in address bar)

Safari can’t run the script “//pushin hover” because Safari doesn’t allow JavaScript to be used in this way. (on page)

[Mark Rowe (bdash)]

<rdar://problem/6809619>

[Cameron Zwarich (cpst)]

Created attachment 29642 [details]
Reduction

Here's a simple reduction:

<a href="javascript://pushin hover">Click here</a>

It works fine (and gets ignored) with a %20 instead of a space.

[Cameron Zwarich (cpst)]

This is an invalid URL, so this check fails, even though the text of the URL begins with "javascript":

    if (!url.protocolIs("javascript"))
        return false;

It seems that when Safari gets a loader callback about this being an invalid URL, it displays the message in the bug report.

I'm not really sure what to do here. Should Safari not display a separate error page, or should we special-case this at the WebKit level?

[Cameron Zwarich (cpst)]

I forgot to mention: that check I am referring to is in FrameLoader::executeIfJavaScriptURL().

[Corey Mitchell]

is there an update on this?  are you guys proceeding with a fix?

[Cameron Zwarich (cpst)]

The fix is to accept some malformed JavaScript URLs. I'm not immediately sure of the right way to go about it, though.

[Alexey Proskuryakov]

This was fixed in <http://trac.webkit.org/changeset/43929>+<http://trac.webkit.org/changeset/43949>.

[Mark Rowe (bdash)]

*** Bug 25995 has been marked as a duplicate of this bug. ***