Bug 25300 - microsoft virtual earth overlay error
Summary: microsoft virtual earth overlay error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://maps.live.com
Keywords: HasReduction, InRadar
: 25995 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-20 14:44 PDT by Corey Mitchell
Modified: 2019-01-02 08:35 PST (History)
3 users (show)

See Also:


Attachments
Reduction (97 bytes, text/html)
2009-04-20 23:43 PDT, Cameron Zwarich (cpst)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Corey Mitchell 2009-04-20 14:44:30 PDT
Create an overlay on the map (collections > add pushpin).  Move the pushpin.  

Error: javascript://pushin%20hover (in address bar)

Safari can’t run the script “//pushin hover” because Safari doesn’t allow JavaScript to be used in this way. (on page)
Comment 1 Mark Rowe (bdash) 2009-04-20 15:07:10 PDT
<rdar://problem/6809619>
Comment 2 Cameron Zwarich (cpst) 2009-04-20 23:43:30 PDT
Created attachment 29642 [details]
Reduction

Here's a simple reduction:

<a href="javascript://pushin hover">Click here</a>

It works fine (and gets ignored) with a %20 instead of a space.
Comment 3 Cameron Zwarich (cpst) 2009-04-20 23:54:02 PDT
This is an invalid URL, so this check fails, even though the text of the URL begins with "javascript":

    if (!url.protocolIs("javascript"))
        return false;

It seems that when Safari gets a loader callback about this being an invalid URL, it displays the message in the bug report.

I'm not really sure what to do here. Should Safari not display a separate error page, or should we special-case this at the WebKit level?
Comment 4 Cameron Zwarich (cpst) 2009-04-21 00:30:40 PDT
I forgot to mention: that check I am referring to is in FrameLoader::executeIfJavaScriptURL().
Comment 5 Corey Mitchell 2009-04-23 09:02:58 PDT
is there an update on this?  are you guys proceeding with a fix?
Comment 6 Cameron Zwarich (cpst) 2009-04-23 12:55:29 PDT
The fix is to accept some malformed JavaScript URLs. I'm not immediately sure of the right way to go about it, though.
Comment 7 Alexey Proskuryakov 2009-05-20 23:13:00 PDT
This was fixed in <http://trac.webkit.org/changeset/43929>+<http://trac.webkit.org/changeset/43949>.
Comment 8 Mark Rowe (bdash) 2009-05-24 15:45:51 PDT
*** Bug 25995 has been marked as a duplicate of this bug. ***