Bug 252946 - REGRESSION (260654@main): BaseXcconfigCheckerTest fails when not run from top-level folder
Summary: REGRESSION (260654@main): BaseXcconfigCheckerTest fails when not run from top...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 244540
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-25 08:31 PST by David Kilzer (:ddkilzer)
Modified: 2023-02-25 10:43 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-25 08:31:45 PST 
BaseXcconfigCheckerTest fails when not run from top-level folder where WebKit is checked out.

It needs to use a relative path based on its location to find Configurations/CommonBase.xcconfig.

Regressed with:

    [Xcode] Simplify sanitizer builds
    https://bugs.webkit.org/show_bug.cgi?id=244540
    <rdar://98015260>
    https://commits.webkit.org/260654@main

<rdar://105893621>
Comment 1 David Kilzer (:ddkilzer) 2023-02-25 08:35:28 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10684
Comment 2 EWS 2023-02-25 10:43:04 PST 
Committed 260840@main (3464e0af6f31): <https://commits.webkit.org/260840@main>

Reviewed commits have been landed. Closing PR #10684 and removing active labels.