Bug 252922 - REGRESSION (260447@main): [Monterey+] TestWebKitAPI.FontManagerTests.ChangeFontWithPanel is consistently failing
Summary: REGRESSION (260447@main): [Monterey+] TestWebKitAPI.FontManagerTests.ChangeFo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-24 11:18 PST by Ryan Haddad
Modified: 2023-02-25 13:06 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2023-02-24 11:18:48 PST 
TestWebKitAPI.FontManagerTests.ChangeFontWithPanel has been consistently failing on macOS after https://commits.webkit.org/260447@main landed. The test is passing on Big Sur, but failing on Monterey and Ventura.

TestWebKitAPI.FontManagerTests.ChangeFontWithPanel
        2023-02-17 09:16:43.579 TestWebKitAPI[1400:24471392] Expected "Helvetica 20.00 pt. P [] (0x7fd520527290) fobj=0x7fd520168410, spc=5.56" to have the same attributes as "Helvetica 20.00 pt. P [] (0x7fd4d7732090) fobj=0x7fd4d7732090, spc=5.56"
        2023-02-17 09:16:43.648 TestWebKitAPI[1400:24471392] Expected "TimesNewRomanPS-BoldMT 10.00 pt. P [] (0x7fd520527290) fobj=0x7fd520527290, spc=2.50" to have the same attributes as "TimesNewRomanPS-BoldMT 10.00 pt. P [] (0x7fd4d775e7b0) fobj=0x7fd4d775e7b0, spc=2.50"
        2023-02-17 09:16:43.713 TestWebKitAPI[1400:24471392] Expected "Arial-BoldItalicMT 14.00 pt. P [] (0x7fd517705190) fobj=0x7fd520338540, spc=3.89" to have the same attributes as "Arial-BoldItalicMT 14.00 pt. P [] (0x7fd51770eea0) fobj=0x7fd51770eea0, spc=3.89"
        
        /Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
        Value of: attributesAreEqual
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
        Value of: attributesAreEqual
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:204
        Value of: attributesAreEqual
          Actual: false
        Expected: true


https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.FontManagerTests.ChangeFontWithPanel
Comment 1 Radar WebKit Bug Importer 2023-02-24 11:19:04 PST 
<rdar://problem/105893191>
Comment 2 Myles C. Maxfield 2023-02-24 17:32:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10674
Comment 3 EWS 2023-02-24 18:46:04 PST 
Test gardening commit 260826@main (7f06b13867ff): <https://commits.webkit.org/260826@main>

Reviewed commits have been landed. Closing PR #10674 and removing active labels.
Comment 4 Wenson Hsieh 2023-02-24 18:56:51 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10676
Comment 5 Seija K. 2023-02-25 07:45:33 PST 
FYI: this happened because the original committer erroneously removed these lines:         
        [fontAttributes1 removeObjectForKey:NSFontVariationAttribute];
        [fontAttributes2 removeObjectForKey:NSFontVariationAttribute];
Comment 6 EWS 2023-02-25 13:06:52 PST 
Committed 260841@main (6d701f331859): <https://commits.webkit.org/260841@main>

Reviewed commits have been landed. Closing PR #10676 and removing active labels.