Bug 25288 – [Qt] Build error in WebCore/editing/visible_units.cpp

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit Qt

[Clemmitt Sigler]

Hi,

Using Qt 4.4.2 on Linux, r42658.  The Qt port build dies on WebCore/editing/visible_units.cpp.  As far as I can tell, in JavaScriptCore/wtf/unicode/Unicode.h, USE(QT4_UNICODE) is defined, but JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h doesn't declare the U16_PREV macro, and JavaScriptCore/wtf/unicode/utf16.h which does declare it doesn't get included.

Build error output is:
-------------------------------
g++ -c -pipe -Wreturn-type -fno-strict-aliasing -march=pentium3 -O2 -pipe -fvisibility=hidden -fvisibility-inlines-hidden -D_REENTRANT -fPIC -DQT_SHARED -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DHAVE_STDINT_H -DBUILD_WEBKIT -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_DOM_STORAGE=1 -DENABLE_ICONDATABASE=1 -DENABLE_DATABASE=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_XPATH=1 -DENABLE_WML=0 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FILTERS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_USE=1 -DENABLE_WORKERS=1 -DENABLE_VIDEO=0 -DENABLE_NETSCAPE_PLUGIN_API=1 -DWTF_USE_JAVASCRIPTCORE_BINDINGS=1 -DWTF_CHANGES=1 -DBUILDING_QT__ -DXP_UNIX -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I/usr/share/qt4/mkspecs/linux-g++ -I../../../WebCore -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I../../../WebCore/storage -I../../../WebKit/qt/Api -I../../../WebCore -I../../../JavaScriptCore -I../../../JavaScriptCore/ForwardingHeaders -I../../../JavaScriptCore/interpreter -I../../../JavaScriptCore/bytecode -I../../../JavaScriptCore/debugger -I../../../JavaScriptCore/parser -I../../../JavaScriptCore/runtime -I/opt/siglercm/webkit/WebKit/WebCore/../JavaScriptCore/bindings -I../../../JavaScriptCore/wrec -I../../../JavaScriptCore/jit -I../../../JavaScriptCore/wtf -Itmp -I../../../JavaScriptCore -I../../../JavaScriptCore/parser -I../../../JavaScriptCore/bytecompiler -I../../../JavaScriptCore/debugger -I../../../JavaScriptCore/runtime -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/wtf/unicode -I../../../JavaScriptCore/interpreter -I../../../JavaScriptCore/jit -I../../../JavaScriptCore/profiler -I../../../JavaScriptCore/wrec -I../../../JavaScriptCore/API -I../../../../WebKit -I../../../JavaScriptCore/ForwardingHeaders -I../../../JavaScriptCore/bytecode -I../../../JavaScriptCore/assembler -I../../../JavaScriptCore/pcre -I../JavaScriptCore/tmp -I../../../WebCore/platform/qt -I../../../WebCore/platform/network/qt -I../../../WebCore/platform/graphics/filters -I../../../WebCore/platform/graphics/transforms -I../../../WebCore/platform/graphics/qt -I../../../WebCore/svg/graphics/qt -I../../../WebCore/loader -I../../../WebCore/page/qt -I../../../WebKit/qt/WebCoreSupport -I../../../WebKit/qt/Api -I../../../WebCore/bridge/qt -I../../../WebCore -I../../../WebCore/ForwardingHeaders -I../../../../WebKit -I../../../WebCore/platform -I../../../WebCore/platform/animation -I../../../WebCore/platform/network -I../../../WebCore/platform/graphics -I../../../WebCore/svg/animation -I../../../WebCore/svg/graphics -I../../../WebCore/svg/graphics/filters -I../../../WebCore/platform/sql -I../../../WebCore/platform/text -I../../../WebCore/loader -I../../../WebCore/loader/appcache -I../../../WebCore/loader/archive -I../../../WebCore/loader/icon -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/page -I../../../WebCore/page/animation -I../../../WebCore/bridge -I../../../WebCore/editing -I../../../WebCore/rendering -I../../../WebCore/rendering/style -I../../../WebCore/history -I../../../WebCore/inspector -I../../../WebCore/xml -I../../../WebCore/html -I../../../WebCore/wml -I../../../WebCore/workers -I../../../WebCore/bindings/js -I../../../WebCore/svg -I../../../WebCore/platform/image-decoders -I../../../WebCore/plugins -I../../../WebCore/bridge -I../../../WebCore/bridge/c -I../../../WebCore/bridge/qt -Itmp -I/usr/src/3rdparty/sqlite/ -I/usr/X11R6/include -I../../../WebCore -I../../../WebCore -I. -o tmp/visible_units.o ../../../WebCore/editing/visible_units.cpp
../../../WebCore/editing/visible_units.cpp: In function 'int WebCore::startOfLastWordBoundaryContext(const UChar*, int)':
../../../WebCore/editing/visible_units.cpp:63: error: 'U16_PREV' was not declared in this scope
../../../WebCore/editing/visible_units.cpp: In function 'WebCore::VisiblePosition WebCore::previousLinePosition(const WebCore::VisiblePosition&, int)':
../../../WebCore/editing/visible_units.cpp:601: warning: passing 'float' for argument 1 to 'WebCore::InlineBox* WebCore::RootInlineBox::closestLeafChildForXPos(int, bool)'
../../../WebCore/editing/visible_units.cpp:605: warning: passing 'float' for argument 1 to 'WebCore::VisiblePosition WebCore::RenderObject::positionForCoordinates(int, int)'
../../../WebCore/editing/visible_units.cpp: In function 'WebCore::VisiblePosition WebCore::nextLinePosition(const WebCore::VisiblePosition&, int)':
../../../WebCore/editing/visible_units.cpp:702: warning: passing 'float' for argument 1 to 'WebCore::InlineBox* WebCore::RootInlineBox::closestLeafChildForXPos(int, bool)'
../../../WebCore/editing/visible_units.cpp:706: warning: passing 'float' for argument 1 to 'WebCore::VisiblePosition WebCore::RenderObject::positionForCoordinates(int, int)'
make[1]: *** [tmp/visible_units.o] Error 1
make[1]: Leaving directory `/opt/siglercm/webkit/WebKit/WebKitBuild/Release/WebCore'
make: *** [sub-WebCore-make_default-ordered] Error 2
-------------------------------
HTH.

Clemmitt

[Tor Arne Vestbø]

Can't reproduce in WebKit trunk (r48110), against Qt 4.6 (77fd77d6) or Qt 4.5.3, on Mac OS 10.5

Please reopen if still valid.