NEW 252856
Style checker should check for incorrect adoptCF() and adoptNS() usage. 
https://bugs.webkit.org/show_bug.cgi?id=252856
Summary Style checker should check for incorrect adoptCF() and adoptNS() usage.
Simon Fraser (smfr)
Reported 2023-02-23 13:37:02 PST
Style bot should have caught the issue fixed in bug 252629.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-02 13:37:22 PST
<rdar://problem/106161245>
Simon Fraser (smfr)
Comment 2 2023-04-12 20:00:54 PDT
This would have caught https://github.com/WebKit/WebKit/pull/12670#pullrequestreview-1382477564
Simon Fraser (smfr)
Comment 3 2023-11-27 12:02:32 PST
Pull request: https://github.com/WebKit/WebKit/pull/20946
Darin Adler
Comment 4 2023-11-27 13:39:09 PST
We will also need the more challenging opposite checker, which checks for use of these function name patterns *without* adoptCF/NS.
Simon Fraser (smfr)
Comment 5 2023-11-27 14:25:22 PST
I think that's impossible to do in the style checker, which doesn't know if a function returns a smart pointer or retained raw pointer.
Darin Adler
Comment 6 2023-11-27 15:05:44 PST
Bummer. I wonder if there’s a way to make it work at least with platform function names, somehow a convention for functions inside WebKit vs. functions from the C and Objective-C functions from CF and Cocoa.
Note You need to log in before you can comment on or make changes to this bug.