Bug 25285 - REGRESSION (r42569): Profiles cannot be selected in inspector profiler
Summary: REGRESSION (r42569): Profiles cannot be selected in inspector profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2009-04-18 17:51 PDT by Geoffrey Garen
Modified: 2009-04-18 18:01 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.58 KB, patch)
2009-04-18 17:51 PDT, Geoffrey Garen
zwarich: review+
Details | Formatted Diff | Diff
patch w/test (5.25 KB, patch)
2009-04-18 17:59 PDT, Geoffrey Garen
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2009-04-18 17:51:12 PDT
4/16/09 2:23 AM Oliver Hunt:
* SUMMARY
Revision r42569 added code that clears the event listener function and globalObject references, which breaks (at the very least) the profiler.

* STEPS TO REPRODUCE
1. Go to https://bugs.webkit.org/attachment.cgi?id=29532
2. Open the inspector
3. Go to the profiles pane
4. enable profiling
5. return to the safari window
6. reload
7. return to the inspector window
8. attempt to focus/select the create profile

* RESULTS
The profile cannot be selected, but we should be able to.  I would guess that this has potential to effect many sites.

* REGRESSION
Introduced by r42569
Commenting out 
 	155	    m_jsFunction = 0; 
 	156	    m_globalObject = 0; 
in JSEventListener::clearJSFunctionInline() 

Restores "Correct" behaviour -- don't know able actual correctness however

4/17/09 2:36 PM David Kilzer:
http://trac.webkit.org/changeset/42569
Comment 1 Geoffrey Garen 2009-04-18 17:51:41 PDT
Created attachment 29601 [details]
patch
Comment 2 Cameron Zwarich (cpst) 2009-04-18 17:53:51 PDT
Comment on attachment 29601 [details]
patch

r=me, but you should either add a test or mention why you can't in the ChangeLog.
Comment 3 Geoffrey Garen 2009-04-18 17:59:49 PDT
Created attachment 29602 [details]
patch w/test

Oops! Forgot to attach the test. Here it is. I'll invalidate the last patch, and mark this one r+.
Comment 4 David Kilzer (:ddkilzer) 2009-04-18 18:01:22 PDT
<rdar://problem/6797442>
Comment 5 Geoffrey Garen 2009-04-18 18:01:43 PDT
http://trac.webkit.org/changeset/42645