Bug 25285 – REGRESSION (r42569): Profiles cannot be selected in inspector profiler

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Geoffrey Garen]

4/16/09 2:23 AM Oliver Hunt:
* SUMMARY
Revision r42569 added code that clears the event listener function and globalObject references, which breaks (at the very least) the profiler.

* STEPS TO REPRODUCE
1. Go to https://bugs.webkit.org/attachment.cgi?id=29532
2. Open the inspector
3. Go to the profiles pane
4. enable profiling
5. return to the safari window
6. reload
7. return to the inspector window
8. attempt to focus/select the create profile

* RESULTS
The profile cannot be selected, but we should be able to.  I would guess that this has potential to effect many sites.

* REGRESSION
Introduced by r42569
Commenting out 
 	155	    m_jsFunction = 0; 
 	156	    m_globalObject = 0; 
in JSEventListener::clearJSFunctionInline() 

Restores "Correct" behaviour -- don't know able actual correctness however

4/17/09 2:36 PM David Kilzer:
http://trac.webkit.org/changeset/42569

[Geoffrey Garen]

Created attachment 29601 [details]
patch

[Cameron Zwarich (cpst)]

Comment on attachment 29601 [details]
patch

r=me, but you should either add a test or mention why you can't in the ChangeLog.

[Geoffrey Garen]

Created attachment 29602 [details]
patch w/test

Oops! Forgot to attach the test. Here it is. I'll invalidate the last patch, and mark this one r+.

[David Kilzer (:ddkilzer)]

<rdar://problem/6797442>

[Geoffrey Garen]

http://trac.webkit.org/changeset/42645