Bug 252727 - Fix build due to availability macros in WKWebpagePreferencesPrivate.h
Summary: Fix build due to availability macros in WKWebpagePreferencesPrivate.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 252437 252641
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-21 23:00 PST by David Kilzer (:ddkilzer)
Modified: 2023-02-21 23:30 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-21 23:00:54 PST 
Fix build due to availability macros in WKWebpagePreferencesPrivate.h.

In file included from WebKitTestRunner/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:52:
WebKit.framework/PrivateHeaders/WKWebpagePreferencesPrivate.h:85:73: error: expected '}' or ','
    _WKWebsiteNetworkConnectionIntegrityPolicyWebSearchContent = 1 << 5 API_AVAILABLE(macos(13.3), ios(NA)),
                                                                        ^
In file included from WebKitTestRunner/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:52:
WebKit.framework/PrivateHeaders/WKWebpagePreferencesPrivate.h:86:74: error: expected '}' or ','
    _WKWebsiteNetworkConnectionIntegrityPolicyEnhancedTelemetry = 1 << 6 API_AVAILABLE(macos(13.3), ios(NA)),
                                                                         ^
In file included from WebKitTestRunner/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:52:
WebKit.framework/PrivateHeaders/WKWebpagePreferencesPrivate.h:87:74: error: expected '}' or ','
    _WKWebsiteNetworkConnectionIntegrityPolicyRequestValidation = 1 << 7 API_AVAILABLE(macos(13.3), ios(NA)),
                                                                         ^
In file included from WebKitTestRunner/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:52:
WebKit.framework/PrivateHeaders/WKWebpagePreferencesPrivate.h:88:84: error: expected '}' or ','
    _WKWebsiteNetworkConnectionIntegrityPolicySanitizeLookalikeCharacters = 1 << 8 API_AVAILABLE(macos(13.3), ios(NA)),
                                                                                   ^

Regressed in Bug 252437 (260627@main) and in Bug 252641 (260632@main).
Comment 1 Radar WebKit Bug Importer 2023-02-21 23:01:32 PST 
<rdar://problem/105765090>
Comment 2 David Kilzer (:ddkilzer) 2023-02-21 23:03:06 PST 
Note:  I used Source/WebKit/Shared/API/Cocoa/_WKRenderingProgressEvents.h to know where to put the availability macros.
Comment 3 David Kilzer (:ddkilzer) 2023-02-21 23:04:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10499
Comment 4 EWS 2023-02-21 23:30:33 PST 
Committed 260660@main (64e9b86994e7): <https://commits.webkit.org/260660@main>

Reviewed commits have been landed. Closing PR #10499 and removing active labels.